UnityDropdown icon indicating copy to clipboard operation
UnityDropdown copied to clipboard

Fix incorrect editor style name for Unity 2022.3+

Open Shimmermare opened this issue 2 years ago • 4 comments

In Unity 2022.3 they fixed typo in style name. https://github.com/Unity-Technologies/UnityCsReference/commit/da51b77dce790fa867436bec018bfd56e464cec4#diff-d4e399fabac0c73f6f6580b4c4094492ab460619fb45fe621764230982beefd3

Same problem in SolidUtilities: https://github.com/SolidAlloy/SolidUtilities/pull/9

Shimmermare avatar Aug 14 '23 13:08 Shimmermare

Would love for this change to go through, stumbled on it today as well.

Velorexe avatar Aug 25 '23 02:08 Velorexe

I think this would break retrocompatibility. A null check and e default to the old typoed string should be preferred.

theGiallo avatar Sep 07 '23 16:09 theGiallo

Oh, sorry I read the unity commit as the one of a PR. You use a define check. Perfect. This also happens in UnityDropdown.

theGiallo avatar Sep 07 '23 16:09 theGiallo

Replaced version defines check with simple null check because this change was ported to Unity 2021, 2022 and 2023.

Shimmermare avatar Oct 04 '23 15:10 Shimmermare