OrcaSlicer icon indicating copy to clipboard operation
OrcaSlicer copied to clipboard

Fix calls to Page::new_optgroup()

Open afmenez opened this issue 9 months ago • 7 comments

Description

Fix the second param on calls to Page::new_optgroup(), which should be an L""

afmenez avatar Feb 25 '25 23:02 afmenez

instead adding parentheses can you remove translation from icon names. i assume its not required to use translation on icon names. @Noisyfox what's your opinion on this.

yw4z avatar Feb 26 '25 00:02 yw4z

The icon names are not translated, the L"" means a wchar literal. What do you mean by "adding parentheses"?

afmenez avatar Feb 26 '25 12:02 afmenez

i was about to send this commit with removing all L on icon names and its already works as normal, you can see my comment in in here https://github.com/SoftFever/OrcaSlicer/pull/7602#issuecomment-2613981574 . just waiting respond for correct way

yw4z avatar Feb 26 '25 14:02 yw4z

If the string conversion happens at compile time, I agree with you that all the L can be removed form all the icon names. If the conversion happens at run time, it's better to add the L on the ones that are missing.

afmenez avatar Feb 26 '25 16:02 afmenez

Have you seen my comment about the "param_extruder_clearence" icon name?

afmenez avatar Feb 26 '25 16:02 afmenez

its a typo mistake, if you want to fix that you should also fix icon name on images folder

yw4z avatar Feb 27 '25 23:02 yw4z

icon visible in here Screenshot-20250228025623

yw4z avatar Feb 27 '25 23:02 yw4z

There seems to be no answer if this is good or bad, so I am closing this one.

afmenez avatar Mar 24 '25 19:03 afmenez