OrcaSlicer
OrcaSlicer copied to clipboard
Fix calls to Page::new_optgroup()
Description
Fix the second param on calls to Page::new_optgroup(), which should be an L""
instead adding parentheses can you remove translation from icon names. i assume its not required to use translation on icon names. @Noisyfox what's your opinion on this.
The icon names are not translated, the L"" means a wchar literal.
What do you mean by "adding parentheses"?
i was about to send this commit with removing all L on icon names and its already works as normal, you can see my comment in in here https://github.com/SoftFever/OrcaSlicer/pull/7602#issuecomment-2613981574 . just waiting respond for correct way
If the string conversion happens at compile time, I agree with you that all the L can be removed form all the icon names. If the conversion happens at run time, it's better to add the L on the ones that are missing.
Have you seen my comment about the "param_extruder_clearence" icon name?
its a typo mistake, if you want to fix that you should also fix icon name on images folder
icon visible in here
There seems to be no answer if this is good or bad, so I am closing this one.