Fixing high GPU usage when color scheme is set to "Filament" or "Speed"

[Azio-Pantheon]

First time contributing, I hope I'm doing this correctly.

Description

Removed imgui.set_requires_extra_frame(), this line causes Slic3r::GUI::GLCanvas3D::render() to be called repeatedly when 'Filament' or 'Speed' is selected in the preview panel (even when OrcaSlicer is minimized)

This should fix #3594

I see that this line was added in #3363. I don't fully understand the intention behind it, but removing this line does not seem to affect the legend window fix

Screenshots/Recordings/Graphs

Now in "Filament" or "Speed" preview, GPU usage is 0% when OrcaSlicer is minimized or idle.

Before:

After:

[vovodroid]

Great finding! It also reduces CPU usage, not only GPU. Merging it into my fork, thanks!

[discip]

@azio25134

Thank you SIR! 😃👍

Am I right to assume that the flow-scheme is also affected?

[vovodroid]

Am I right to assume that the flow-scheme is also affected?

I don't see such problem in Orca 2.1.1, so your fix affects only Filament and Speed.

[Azio-Pantheon]

@azio25134

Thank you SIR! 😃👍

Am I right to assume that the flow-scheme is also affected?

It only affects Filament and Speed as far as I know.

[birdoplo]

In which file is the string imgui.set_requires_extra_frame() ?

[vovodroid]

See changes https://github.com/SoftFever/OrcaSlicer/pull/6223/files