Parameter box improvements

[yw4z]

Adds missing / empty side texts

• Added "Layers" side text for

Top shell layers Bottom shell layers Number of slow layers

• Added "Layer" side text for

Full fan speed at layer

• Added "x" side text for ratios. This one looks nice imo

Flow ratio Top surface flow ratio Bottom surface flow ratio Internal bridge flow ratio Bridge flow ratio Scarf joint flow ratio

• Added "mm" side text for

Mesh margin Minimum wall length

• Added "°C" side text for

Softening temperature

Fixes combo boxes without arrows

Support > Style

Filament Supports

Support > Advanced

after fix shows dropdown arrows if there is no icon for dropdown item

Converts double input boxes to regular input boxes

After Fix • Used icons for X / Y instead text. input boxes aligns perfectly with other components • Didn't use combined side text because it not matches style with other components • Solves styling problem and gives same result on all platforms

Preview for Printer Settings > Printable Area > Set

before	after

Also matched style of Create printer window • Used text align on left like on other components • Matched width of input boxes with other components

before	after

Better background color for disabled elements

• Old one is just pops a bit much in dark mode

new vs old

Updated text color on disabled text elements and Matched combo box disabled text color

• Used same color for combo box disabled text. now its matches with other components • With different color, combo box text looks like its bold compared to regular text input while they in disabled state • Used slightly darker color disabled text on dark mode to match with new background color

before	after

Questionable areas for discussion (EXCLUDED FROM COMMIT)

• Converting these to spin boxes. Currently it combines combo box and input box and it has weird usage and no need to use on this ones because dropdown only shows numbers without any description. Using spin boxes better because other layer related input boxes uses this too

Top interface layers Bottom interface layers

I noticed there is a "Same as Top" option for Bottom interface layers. I guess i will revert back to default with your comment

not rendered well with side text

solution with spin box. there is an explanation required on tooltip for -1 equals same as top

Also this ones combines combo box and input box. like i said its weird but helpful on this ones compared to interface layers ones

sparse_infill_line_width infill_anchor_max infill_anchor

If you planning to add more pre defined values for value boxes in future maybe increasing width of input boxes will be a good choice because value + dropdown arrow + side text looks very dense

I tried to make use them as regular input box in my UI commit but probably revert back with your comment

[discip]

1. • Added "Layers" side text for

   • Added "Layer" side text for

   Regarding all the 'side texts', you should consider the context:

   If the corresponding unit is used in the description in front of the value, there is no need to put it additionally thereafter.

   

2. • Added "mm" side text for

   &

   • Added "°C" side text for

   👍

3. • Converted these to spin boxes ...

   • Due to the mentioned reason in 1., no need for 'side texts' here as well.
   • Since a drop-down allows you to access all the values ​​more quickly without having to click through them individually, as would be the case using a spin box, please leave this as is.

4. I tried to make use them as regular input box in my UI commit but probably revert back with your comment

   Please don't remove the arrow.

[yw4z]

@discip then we should delete these with your logic

side text generally uses units and its unit "Layer" / "Layers" in my perspective

problem is combining combo box and and input box and parameter value boxes too narrow to fit multiple components

about spin boxes you can set value faster with them compared to combo box

[discip]

1. then we should delete these with your logic

   Absolutely! 😃👍 I haven't checked every other possible case, but since you're at it, it would be great if you maintained the tendency you've demonstrated to make everything as consistent as possible. 😊

2. side text generally uses units and its unit "Layer" / "Layers" in my perspective

   To demonstrate what I mean: Compared to e.g.: length, where you could have mm or cm, in which case it makes perfect sense to put the unit in the text box, even though the description contains the word length, the 'unit' layers doesn't need any further specification.

3. problem is combining combo box and and input box and parameter value boxes too narrow to fit multiple components

   I'm having no issues using the current setup. 🤷🏻

4. about spin boxes you can set value faster with them compared to combo box

   1. It depends on the amount of values the list contains.
   2. In most cases you would need 2 clicks to get any value with a drop down opposed to a spin box. e.g.: If your current value is 1 you would need to click 4 times to get to the 5 with a spin box. With a drop down however, you click the arrow and 5 (2 clicks)!

I'm really curious about what others think about these changes.

[yw4z]

4. about spin boxes you can set value faster with them compared to combo box

   1. It depends on the amount of values the list contains.
   2. In most cases you would need 2 clicks to get any value with a drop down opposed to a spin box. e.g.: If your current value is 1 you would need to click 4 times to get to the 5 with a spin box. With a drop down however, you click the arrow and 5 (2 clicks)!

you just count mouse clicks. you should also count mouse movements as steps

[yw4z]

@SoftFever this commit also ready for review. also there is a "Questionable areas for discussion" section on first post

[yw4z]

@SoftFever should i split this commit to separate commits • Add missing side texts for parameter boxes • Fix combo box arrows not appearing if there is no icon for drop down list item • Convert double input boxes for points to regular input boxes • Better color for disabled elements on dark mode (Will move this to new color fixes commit) • Match text color of disabled combo box (Will move this to new color fixes commit)

[yw4z]

@SoftFever updated point control icons before

after

[SoftFever]

@yw4z What's the status of the PR? Could we remove the x sidenote?

[yw4z]

@SoftFever yes i will remove them but quite busy atm. probably complete changes on PRs on end of week

[yw4z]

@SoftFever reverted changes for "x" side text and removed color related fixes because they need additional changes. i will send color related issues as another commit because i found 10+ more

btw why this one not uses percentages. it will make it easier to understand