ModelOrderReduction icon indicating copy to clipboard operation
ModelOrderReduction copied to clipboard

Examples from /sofiaLeg/sofiaComplete/ are broken

Open epernod opened this issue 1 year ago • 0 comments

To clean the ci I tried to fix the scenes below but didn't succeed:

  • softRobots/sofiaLeg/sofiaComplete/sofiaSixLegs.py
  • softRobots/sofiaLeg/sofiaComplete/DemoSofia.py (which in fact is just using sofiaSixLegs.py)

I already fixed several issues in https://github.com/SofaDefrost/ModelOrderReduction/pull/138 but there was still some problem, which required more knowledge of the modelling of that robot. Especially regarding the call of:

leg , myController =    addSofia(sofia,
                                        name=name+str(i),
                                        rotation=rotation,
                                        translation=legPosition[i],
                                        scale=scale,
                                        surfaceColor=[0.0, 0.0, 1, 0.5],
                                        controller=actuatorArg[i],
                                        surfaceMeshFileName=surfaceMeshFileName)

refering to either SofiaLeg or Reduced_SofiaLeg which seems to have change (not the same parameters and returns)


As soon as those scene are fixed, they can be restore on the ci tests by removing the lines:

ignore "softRobots/sofiaLeg/sofiaComplete/sofiaSixLegs.py" # TODO fix: many errors in the scripts, methods signature changed, SOFA scene using old SofaPython API
ignore "softRobots/sofiaLeg/sofiaComplete/DemoSofia.py" # TODO fix: depends on sofiaSixLegs.py . Should be fixed if sofiaSixLegs.py is working

in https://github.com/SofaDefrost/ModelOrderReduction/blob/master/examples/.scene-tests

epernod avatar Aug 29 '24 09:08 epernod