KeyDB icon indicating copy to clipboard operation
KeyDB copied to clipboard

Published 20 hours ago • verified publisher icon Snapchat

Allow to use system provided rocksdb

Open chenrui333 opened this issue 2 years ago • 4 comments

Right now, keydb build is hard linked to the vendored rocksdb, I wonder if it is a good idea to use a system provided rocksdb to ease the build/installation.

https://github.com/Snapchat/KeyDB/blob/c3343ddbd753cdc28638de92b6fa1a51f2ad1d78/src/Makefile#L75-L81

https://github.com/Snapchat/KeyDB/blob/c3343ddbd753cdc28638de92b6fa1a51f2ad1d78/src/Makefile#L440

relates to https://github.com/Homebrew/homebrew-core/pull/121287

chenrui333 avatar Jan 23 '23 01:01 chenrui333

The vendored rocksdb was due to some compile fixes we needed for 6.3.2, we will go back to using rocksdb as a submodule and attempt to stay up to date with the latest release of rocksdb going forward. We can add optional system provided rocksdb once we are stable with latest rocksdb.

msotheeswaran-sc avatar Jan 23 '23 20:01 msotheeswaran-sc

We can add optional system provided rocksdb once we are stable with latest rocksdb.

yeah, that is what I aim for. this would save build/installation time.

chenrui333 avatar Jan 24 '23 16:01 chenrui333

homebrew side kept the rocksdb release fairly up to date, I assume it would be the same for other package managers, so it would be definitely good to add the option of using the system provided rocksdb :)

chenrui333 avatar Jan 24 '23 16:01 chenrui333

This is now implemented in git main, you can use USE_SYSTEM_ROCKSDB=yes to avoid using the vendored dependency. So I guess this can be closed?

guillemj avatar Mar 28 '24 14:03 guillemj