wireless-adb-switch icon indicating copy to clipboard operation
wireless-adb-switch copied to clipboard

[FEATURE] Automation

Open sleeping3119 opened this issue 1 year ago • 5 comments

This app is very good but important feature is missing. It should have ability to open port automatically if it is connected to trusted/home network (chosen by user).

And if it need location permission everytime for this then i would reccomend go for root shell solution it would be more battery friendly.

sleeping3119 avatar Aug 10 '24 08:08 sleeping3119

+1

Having it automatically enable when connected to a trusted network would be awesome!

Its annoying not being able to connect to your phone in the other room because WADB isnt enabled. Getting up to grab your phone to enable WADB kinda defeats the purpose. Might as well connect it to your PC with a wire at that point.

znbaboy avatar Feb 17 '25 22:02 znbaboy

IDK about this other stuff, but the supposed automatic wireless debugging enable doesn't work AT ALL, so this program does LITERALLY NOTHING. I've tried it on a phone and two different tablets, one a Samsung. It doesn't work. You're better off using a shortcut to developer options. There's also been no updates in a year. What's this program actually do? Is it a crypto miner? The widget also doesn't update itself very well. Nothing works properly. You can have wireless enabled and it says it's disabled.

DefectiveByDesign avatar May 28 '25 20:05 DefectiveByDesign

so this program does LITERALLY NOTHING

Still works for me on an Android 14 custom ROM. The program is intended to be a shortcut to enable / disable wireless ADB. If it did not work for you, create an issue and provide more info: what are your devices, what versions of OS they are running, whether you are rooted or using Shizuku. This app is a hack to make developers' life easier, so it depends on what you are running a lot.

You're better off using a shortcut to developer options. There's also been no updates in a year.

Well, you are free to use whatever you want, as well as I am free to maintain my project whenever I want to.

Is it a crypto miner?

of course! (It is not). You may learn Kotlin and bring in the updates you are talking about, though. This way you'll also be able to check, whether this is a miner.

Actually though, just stay a bit more polite and descriptive on the issue tracker. Thank you!

Smooth-E avatar May 29 '25 09:05 Smooth-E

Specifically WADBS doesn't auto enable wireless, but pretends it can do it. If it requires root, the option should be greyed out, but I don't believe it requires root. If the feature requires specific hardware, that should be a public disclaimer, and I have never found a device that works. Second, enabling wireless by ITSELF doesn't help shizuku use AT ALL, because Shizuku requires you to disable then re-enable USB debugging to work correctly, or more accurately restart Shizuku, which disabling USB debugging does for whatever reason.

WADBS kinda advertises itself as an auto start Shizuku assistant, but does none of this. You can open Shizuku directly and get shortcuts that WADBS doesn't provide. WADBS also does not monitor the wireless debugging mode state for automatic re-enabling if you are using a Samsung device that times out the feature.

The only function that works is the widget button for manual use, but like I said it won't allow shizuku to run without being reset, and there have been cases where the button doesn't work right, since it's not 100% in sync, and can get confused.

I've tried android devices from android 10 through 13. Every version in between. None enable automatically. I've tried 2 Motorola phones, 3 tablets, one being a Samsung, and a Odin 2 gaming handheld. The supposed automatic mode never enables wireless debugging by itself, and Shizuku won't run regardless because the service requires a reset.

I don't see how this app makes anyone's "life easier". The only exception I can think of is rooted devices, which isn't documented properly if so, and shizuku itself provides a root function.

If the app wants to claim it has a purpose, it needs to actually enable wireless debugging automatically, and maybe provide a function for restarting shizuku, so the service can boot without manual intervention. The way it works now doesn't help, and it's just a notification widget. That, and the clipboard function, which I don't use. So I suppose it does serve a purpose for people who use the clipboard. I just assumed the purpose was to help start shizuku, and it doesn't.

DefectiveByDesign avatar May 31 '25 02:05 DefectiveByDesign

Specifically WADBS doesn't auto enable wireless, but pretends it can do it. If it requires root, the option should be greyed out, but I don't believe it requires root. If the feature requires specific hardware, that should be a public disclaimer, and I have never found a device that works. Second, enabling wireless by ITSELF doesn't help shizuku use AT ALL, because Shizuku requires you to disable then re-enable USB debugging to work correctly, or more accurately restart Shizuku, which disabling USB debugging does for whatever reason.

Enabling wireless debugging at device startup requires root because you cannot use WADBS with Shizuku backend, only if Shizuku was enabled through wired debugging (i.e. you connected the phone to your PC via cable and executed the commands). This is due to, what you described, the nature of WADBS: it switched wireless ADB on or off, thus you cannot rely on wireless ADB to power Shizuku.

I may or may not add a notice or grey-out the option, it will depend on how the options will be laid out after I add the automation feature requested in this issue. Thanks for pointing this out.

WADBS kinda advertises itself as an auto start Shizuku assistant, but does none of this.

No, it does not. From what did you assume this? I would like to adjust branding to prevent such misconceptions from occurring later.

You can open Shizuku directly and get shortcuts that WADBS doesn't provide.

Well, because WADBS only provides one shortcut: to enable or disable wireless ADB. And it provides this shortcut in form of a widget, a QS tile and QS View for One UI 2.1 (and possibly others) if you will. Additional functionality includes allowing you to quickly copy pairing info (address and port) and sending this info to your PC via KDE Connect.

Shizuku is a backend for WADBS, not the other way around. WADBS exists independent of Shizuku and is meant for things described above, not to assist or otherwise with Shizuku specifically. If you will, please, point out pieces of branding that made you think otherwise.

WADBS also does not monitor the wireless debugging mode state for automatic re-enabling if you are using a Samsung device that times out the feature.

Consider submitting a separate issue for that and providing more details on this.

I've tried android devices from android 10 through 13. Every version in between. None enable automatically. I've tried 2 Motorola phones, 3 tablets, one being a Samsung, and a Odin 2 gaming handheld. The supposed automatic mode never enables wireless debugging by itself, and Shizuku won't run regardless because the service requires a reset.

Wireless ADB is only present on Android 11 and above. I am surprised you managed to install WADBS on Android 10, because it targets SDK 30 minimum (which is Android 11).

I don't see how this app makes anyone's "life easier". The only exception I can think of is rooted devices, which isn't documented properly if so, and shizuku itself provides a root function.

If you use a device running Android 11+ and set up Shizuku using a PC, then you can use widgets and the QS tile to enable or disable wireless ADB and copy connection details. You cannot use any other features.

I think that using a widget that's right on your home screen is much faster, than digging through developer options to enable wireless ADB and check out the connection details. This is how my app may make your developer life easier. Yes, on non-rooted device you get considerably less functionality, but keep in mind, that this app is a bunch of hidden restricted API calls taped together.

If the app wants to claim it has a purpose, it needs to actually...

Nah, if something I made claims it has a purpose, it does not need to exceed any expectations, apart from the ones I put into it. If you need something extra, I may spare some time to add it.

...and maybe provide a function for restarting shizuku, so the service can boot without manual intervention.

When I made the app, I wanted to practice reading Android's source code and hack some things around. I made the app root-only. Later, the audience grew, and users requested support for using the app without root. So, I made it possible: now some features are available without root, with the help of Shizuku. See? Now the app has purpose for more people, but it does not mean it did not have it before. 🙂

The way it works now doesn't help, and it's just a notification widget. That, and the clipboard function, which I don't use. So I suppose it does serve a purpose for people who use the clipboard.

Exactly. It was fun reading through your journey to such conclusion. Really.

So I suppose it does serve a purpose for people who use the clipboard. I just assumed the purpose was to help start shizuku, and it doesn't.

Yeah, because it is not meant to. Again, you can recap on pieces of branding that confused you into thinking this way, and we will work on improving it.

Thanks for taking interest in trying WADBS on that many devices. If you found any bugs in the intended behavior of WADBS, insights are appreciated! Continue on keeping the relaxed and polite tone in the conversations online, it is much more interesting and easy to communicate this way.

Smooth-E avatar May 31 '25 20:05 Smooth-E