TokenScript icon indicating copy to clipboard operation
TokenScript copied to clipboard

Approved to move and Gave approval to move activities title are truncated

Open hboon opened this issue 5 years ago • 2 comments
trafficstars

These 2 activities seem to frequently be associated with a large value that the following text is often (always?) truncated:

Approved to move <symbol>

and:

Gave approval to move <symbol>

Maybe truncate middle or hide the value completely for these 2 activities?

hboon avatar Sep 18 '20 03:09 hboon

I checked MetaMask and in their Activity, they simply hid the amount that is approved.

screenshot

Is it urgent? The reason I ask is that it seems all dapps today approved a maximum possible number (transaction generated by Uniswap). So I may update the code to show "Unlimited" instead. That requires a bit of JS detective work.

screenshot

SmartLayer avatar Sep 20 '20 23:09 SmartLayer

Not urgent

hboon avatar Sep 21 '20 00:09 hboon