SlimeVR-Server icon indicating copy to clipboard operation
SlimeVR-Server copied to clipboard

Published 20 hours ago • verified publisher icon SlimeVR

Drift compensation should take minutes instead of resets

Open Erimelowo opened this issue 1 year ago • 4 comments

Erimelowo avatar Feb 28 '24 12:02 Erimelowo

The "last x resets" UI paradigm is not ideal. It allows a few overly short yaw resets to have undue influence on the average drift, causing erroneous compensation values.

Better might be "last x minutes", where the SlimeVR Server stores a record of all yaw resets performed in the listed time period and averages them.

xenimax avatar Feb 28 '24 18:02 xenimax

quick successive resets are not taken into account because there’s a 50sec timer between resets

Erimelowo avatar Feb 28 '24 18:02 Erimelowo

what if someoe does a yaw reset, realizes they were posed the wrong way, and tries again? i think the latest reset should override the previous recording if it was within 50 seconds ago

ThomasSteve83 avatar Dec 13 '24 15:12 ThomasSteve83

what if someoe does a yaw reset, realizes they were posed the wrong way, and tries again? i think the latest reset should override the previous recording if it was within 50 seconds ago

That’s actually what it does

https://github.com/SlimeVR/SlimeVR-Server/blob/e8afb49685854d636905c7d545b7832060e89dc3/server/core/src/main/java/dev/slimevr/tracking/trackers/TrackerResetsHandler.kt#L489

Erimelowo avatar Dec 13 '24 15:12 Erimelowo