SkyzohKey
[macos] Problem with icon
Hi, How you can see, the icons are not know in macos, a solution can be to use all icon in a external file. Furthermore the icons of contact are narrowed :/
Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
C'est bizarre vu que la flèche de droite est chargée depuis les ressources. En tout cas c'est beau, ça tourne nickel (ou presque) sur OSX, vive Vala ! 👌👌
Tu peux m'envoyer les logs du terminal quand tu lance Konv ?
Ça me fait la même avec parol, tout les icones implicites ( genrent le bouton fermer dans la headerbar apparaissent cassé >< )
OK faudrait que j'ajoute le thème d'icônes dans les dépendances alors ! Reste que la flèche est tjrs pas là 😑
J'ai ça comme sortie, ça peut peut être t'aider ? ‘‘‘ (konv:16641): Gdk-WARNING **: GdkQuartzDisplay does not implement the monitor vfuncs
(konv:16641): Gtk-CRITICAL **: gtk_toggle_button_set_active: assertion 'GTK_IS_TOGGLE_BUTTON (toggle_button)' failed
(konv:16641): Gtk-CRITICAL **: gtk_bin_get_child: assertion 'GTK_IS_BIN (bin)' failed
(konv:16641): Gtk-CRITICAL **: gtk_widget_get_style_context: assertion 'GTK_IS_WIDGET (widget)' failed
(konv:16641): Gtk-CRITICAL **: gtk_widget_set_tooltip_text: assertion 'GTK_IS_WIDGET (widget)' failed
(konv:16641): Gtk-CRITICAL **: gtk_style_context_remove_class: assertion 'GTK_IS_STYLE_CONTEXT (context)' failed
(konv:16641): Gtk-CRITICAL **: gtk_style_context_add_class: assertion 'GTK_IS_STYLE_CONTEXT (context)' failed
(konv:16641): Gtk-CRITICAL **: gtk_container_add: assertion 'GTK_IS_CONTAINER (container)' failed
(konv:16641): Gtk-CRITICAL **: gtk_widget_set_visible: assertion 'GTK_IS_WIDGET (widget)' failed
(konv:16641): Gtk-CRITICAL **: gtk_widget_get_style_context: assertion 'GTK_IS_WIDGET (widget)' failed
(konv:16641): Gtk-CRITICAL **: gtk_style_context_remove_class: assertion 'GTK_IS_STYLE_CONTEXT (context)' failed
(konv:16641): Gtk-WARNING **: Could not load a pixbuf from /org/gtk/libgtk/theme/Adwaita/assets/bullet-symbolic.svg. This may indicate that pixbuf loaders or the mime database could not be found. ‘‘‘
Pour les avatars, c'est un problème lié au retina je pense, faudra que je multiplie la taille du Pixbuf par 2 je pense.
Problème résolue dans AvatarWidget.vala:
...
#if OSX
cr.scale (0.5 / scale_factor, 0.5 / scale_factor);
#else
cr.scale (1.0 / scale_factor, 1.0 / scale_factor);
#endif
cr.new_path ();
Utils.cairo_rounded_rectangle (cr, EXTRA_MARGIN + 2, EXTRA_MARGIN + 2, width - 2, height - 2, crop_radius);
Gdk.cairo_set_source_pixbuf (cr, pixbuf, EXTRA_MARGIN * scale_factor, EXTRA_MARGIN * scale_factor);
cr.fill_preserve ();
cr.restore ();
style_context.render_background (cr, EXTRA_MARGIN + 1, EXTRA_MARGIN + 1, width - 1, height - 1);
style_context.render_frame (cr, 0, 0, width, height);
} else {
cr.save ();
#if OSX
cr.scale (0.5 / scale_factor, 0.5 / scale_factor);
#else
cr.scale (1.0 / scale_factor, 1.0 / scale_factor);
#endif
style_context.render_icon (cr, pixbuf, EXTRA_MARGIN, EXTRA_MARGIN);
cr.restore ();
}
suffit de passer au valac "-D OSX", mais je ne sais pas comment faire ça avec make ><
C'est corrigé 😊. Tu sais me faire un screen please ? C'est pour le Readme. 😎
J'arrive plus à complier 😞
Scanning dependencies of target i18n
[ 0%] Built target i18n
[ 5%] Generating /Users/ogromny/Desktop/Konv/build/src/Config.c;core/ToxSession.c;Konv.c;utils/RoundImage.c;gui/components/HeaderBar.c;gui/components/SettingsListBox.c;gui/components/TabContainer.c;gui/components/TabNavbar.c;gui/widgets/BaseView.c;gui/widgets/WelcomeView.c;gui/widgets/AvatarWidget.c;gui/widgets/ContactPreview.c;gui/widgets/ContactListRow.c;gui/windows/MainWindow.c;gui/windows/SettingsWindow.c
/bin/sh: -c: line 0: syntax error near unexpected token `('
/bin/sh: -c: line 0: `cd /Users/ogromny/Desktop/Konv/build/src && /usr/local/bin/valac -C -b /Users/ogromny/Desktop/Konv/src -d /Users/ogromny/Desktop/Konv/build/src --pkg=gtk+-3.0 --pkg=json-glib-1.0 --pkg=libtoxcore --vapidir="/Users/ogromny/Desktop/Konv/src/vapis" --target-glib="2.38" --gresources=/Users/ogromny/Desktop/Konv/data/konv.gresource.xml --disable-warnings IF ( Darwin MATCHES Darwin ) --DSYSTEM_OSX ENDIF ( Darwin MATCHES Darwin ) -g /Users/ogromny/Desktop/Konv/build/src/Config.vala /Users/ogromny/Desktop/Konv/src/core/ToxSession.vala /Users/ogromny/Desktop/Konv/src/Konv.vala /Users/ogromny/Desktop/Konv/src/utils/RoundImage.vala /Users/ogromny/Desktop/Konv/src/gui/components/HeaderBar.vala /Users/ogromny/Desktop/Konv/src/gui/components/SettingsListBox.vala /Users/ogromny/Desktop/Konv/src/gui/components/TabContainer.vala /Users/ogromny/Desktop/Konv/src/gui/components/TabNavbar.vala /Users/ogromny/Desktop/Konv/src/gui/widgets/BaseView.vala /Users/ogromny/Desktop/Konv/src/gui/widgets/WelcomeView.vala /Users/ogromny/Desktop/Konv/src/gui/widgets/AvatarWidget.vala /Users/ogromny/Desktop/Konv/src/gui/widgets/ContactPreview.vala /Users/ogromny/Desktop/Konv/src/gui/widgets/ContactListRow.vala /Users/ogromny/Desktop/Konv/src/gui/windows/MainWindow.vala /Users/ogromny/Desktop/Konv/src/gui/windows/SettingsWindow.vala'
make[2]: *** [src/konv_valac.stamp] Error 2
make[1]: *** [src/CMakeFiles/konv.dir/all] Error 2
make: *** [all] Error 2
Scanning dependencies of target i18n
[ 0%] Built target i18n
[ 5%] Generating /Users/ogromny/Desktop/Konv/build/src/Config.c;core/ToxSession.c;Konv.c;utils/RoundImage.c;gui/components/HeaderBar.c;gui/components/SettingsListBox.c;gui/components/TabContainer.c;gui/components/TabNavbar.c;gui/widgets/BaseView.c;gui/widgets/WelcomeView.c;gui/widgets/AvatarWidget.c;gui/widgets/ContactPreview.c;gui/widgets/ContactListRow.c;gui/windows/MainWindow.c;gui/windows/SettingsWindow.c
Option inconnue --DSYSTEM_
Run '/usr/local/bin/valac --help' to see a full list of available command line options.
make[2]: *** [src/konv_valac.stamp] Error 1
make[1]: *** [src/CMakeFiles/konv.dir/all] Error 2
make: *** [all] Error 2
:/
Je vois, ducking correcteur automatique, je suis sur phone, laisse moi fix ça :')
/Users/ogromny/Desktop/Konv/src/gui/widgets/AvatarWidget.vala:193.29-193.40: error: The name `scale_facotr' does not exist in the context of `Konv.Gui.Widgets.Avatar.draw'
cr.scale (1.0 / scale_facotr, 1.0 / scale_factor);
Avec la bonne variable ça ne marche toujours pas même :'(
Bah ça compile mais les icônes sont toujours petite ça prend pas en compte que je compile sous macos :|
Ok je viens de corriger ça, normalement tu peux compiler avec
cd build
cmake .. -DCMAKE_INSTALL_PREFIX=/usr -DKONV_BUILD_OS=OSX
make
./src/konv
