ImageSharp.Drawing icon indicating copy to clipboard operation
ImageSharp.Drawing copied to clipboard

Published 20 hours ago • verified publisher icon SixLabors

Review and fix parameter names and XML docs in extension methods

Open antonfirsov opened this issue 5 years ago • 2 comments

There are many leftovers from the time when extension methods used to operate on an image:

https://github.com/SixLabors/ImageSharp.Drawing/blob/799d6afce0749f3316f6e766ac8884cccc9ef46b/src/ImageSharp.Drawing/Processing/Extensions/DrawLineExtensions.cs#L95-L100

antonfirsov avatar Oct 16 '20 14:10 antonfirsov

I believe it would be better to address this in RC1.

antonfirsov avatar Jun 18 '21 14:06 antonfirsov

Agreed

JimBobSquarePants avatar Jun 18 '21 18:06 JimBobSquarePants

I've been reading through the docs and it looks like I've fixed all the issues over time in other PRs. I'm going to close this as it's looking good.

JimBobSquarePants avatar Aug 13 '23 10:08 JimBobSquarePants

This is not true:

https://github.com/SixLabors/ImageSharp.Drawing/blob/b059f3142106b9bf12922acd5f25156a41cc1fe6/src/ImageSharp.Drawing/Processing/Extensions/DrawBezierExtensions.cs#L76-L82

An easy way to address this would be to run a find & replace for The image this method extends.

antonfirsov avatar Aug 14 '23 08:08 antonfirsov