Cinder
Well, I've been reviewing and testing this for the past 5 hours, and I do not have any complaints. As with everything, I am sure that there will be issues...
I am fine with leaving the settings constants as they are for now. If no adjustments are needed there, they can be removed down the line. As for the other...
Sorry, things got a little hectic with the April Fool's event... and with bugfixes for it. I've reviewed the PR, and will merge it in time for the Wednesday's release,...
Had a test fail randomly in a completely unrelated commit. ``` Failure: TagQueryTest#test_: Parsing a query: should correctly handle wildcards. [test/unit/tag_query_test.rb:745]: Expected: ["acb", "azb"] Actual: ["azb", "acb"] bin/rails test test/unit/tag_query_test.rb:742...
Closed in favor of #1048.
Closed in favor of #987.
This issue was fixed / bypassed in the thumbnail rework.
Interesting idea. I don't necessarily agree that this specific icon you chose is an improvement, though.