Simple-Keyboard icon indicating copy to clipboard operation
Simple-Keyboard copied to clipboard

Add functionality to set keyboard height

Open jacobkapitein opened this issue 3 years ago • 4 comments

This is my first open source contribution, so please give any feedback regarding code, set-up of the pull request and the process.

I missed functionality to set the height of the keyboard. I used other keyboard before and switched to this one, due to the simplicity. The keyboard however, was a lot smaller than I was used to so I created this functionality.

In the pull request I tried following all rules noted here.

There are now 3 modes to set the keyboard: Small, Medium and Big/Large. It's just a really simple setting with a list of all options available. I tried different methods, including a textbox, radio buttons and the one implemented now: a pop-up with some options, comparable to the language selection.

Again: I really wanted this functionality and decided to maybe help out and implement it myself. Hope you like it.

If any code needs to be edited, changed, refactored or anything, please let me know. I am open to feedback.

jacobkapitein avatar Jul 28 '22 18:07 jacobkapitein

resolve the conflicts please, meanwhile I already added the keyboard_height string to main repository so people can translate it

tibbi avatar Jul 31 '22 15:07 tibbi

I will resolve the conflict, fix the issues and update the pull request before this weekend.

I assume you checked the code already then?

jacobkapitein avatar Aug 02 '22 19:08 jacobkapitein

not yet, didnt get to that part directly

tibbi avatar Aug 02 '22 19:08 tibbi

Resolved the conflicts and resolved your comments.

jacobkapitein avatar Aug 03 '22 18:08 jacobkapitein

looks good, will see if this is what people expected :) Thanks

tibbi avatar Aug 15 '22 20:08 tibbi