Simple-Gallery icon indicating copy to clipboard operation
Simple-Gallery copied to clipboard

regression Keep old last-modified value at file operations

Open jmichael2497 opened this issue 3 years ago • 51 comments

Android 11 Lineage OS 2021-12-16 on LG v20 (H918)

f-droid Simple Gallery Pro 6.22.2 and 6.22.3 "keep old last-modified value at file copy/move/rename" and "recycle bin" and standard external SD DCIM Camera folder.

any file movement between sd card folders or recycling does not preserve the "last modified" file system level timestamp.

recently upgraded from 10 to 11, so for comparison f-droid Ghost Commander moves files as expected without affecting date.

so it seems to be an app specific regression, and yes i've tried turning it (setting and phone) off and on :)

hope that helps.

edit to add: noticed that with 6.22.3 (f-droid) running on LOS 11 still, it seems like maybe after a reboot (since it can be a week later sometimes) the file last modification timestamp gets updated, so... 🤷🏽‍♂️

jmichael2497 avatar Dec 28 '21 03:12 jmichael2497

After updating from ~~6.21.2~~ 6.22.3 to 6.23.1 on Android 12, "last modified" value is lost during any file operations. In addition to that, sometimes I'm getting a prompt asking me to confirm deletion of the old file after moving it to a new location, and I need to grant access permissions for each individual folder. For all intents and purposes, this app is now useless for any operations other than just viewing images. I'm forced to use a different app to move them between folders.

Even if Google now requires the app to work like this to be published in the Play Store, there's no excuse for the F-Droid version to be handicapped too.

nbmrjuhneibkr avatar Apr 19 '22 12:04 nbmrjuhneibkr

I'm also having this issue. Very frustrating as it completely ruins organization.

sam-the-enby avatar Apr 29 '22 20:04 sam-the-enby

should be working on Android 12 from 6.23.2, I cant seem to fix it on Android 11

tibbi avatar Apr 29 '22 21:04 tibbi

Now in v6.32.2 (pro) when I move a file, it changes the modified time to 5pm on December 31st, 1969. Presumably this is just the unix epoch adjusted for my time zone, so it's setting the modified time to all zeroes. Android 12

sam-the-enby avatar May 01 '22 15:05 sam-the-enby

does it even show that date in the Properties dialog?

tibbi avatar May 01 '22 16:05 tibbi

yes

sam-the-enby avatar May 01 '22 16:05 sam-the-enby

I cant seem to fix it on Android 11

Does this stand for "I haven't found a solution yet" or "the API on Android 11 is too limited, and this issue will stay there permanently"?

Either way, I believe that https://github.com/SimpleMobileTools/Simple-Gallery/issues/2417 should be revisited.

nbmrjuhneibkr avatar May 02 '22 01:05 nbmrjuhneibkr

I was researching it a lot, found no solution on Android 11

tibbi avatar May 02 '22 11:05 tibbi

I also have this error but it occurs randomly in version 6.23.2 android 12. The moved images have a modification date of 1970-01-01, 01:00 photo_2022-05-02_19-24-55

J4CKED avatar May 02 '22 17:05 J4CKED

how about the original file? Does it also show a similar date?

tibbi avatar May 02 '22 19:05 tibbi

Yes, the photo does not need to be edited.

J4CKED avatar May 02 '22 20:05 J4CKED

I mean if you check the original file properties before copying, does it also show yearh 1970?

tibbi avatar May 02 '22 20:05 tibbi

No, the original photos have the correct date. I have sorting set to by modification date and these moved photos go to the end of the gallery.

J4CKED avatar May 02 '22 20:05 J4CKED

I can't say, I moved the file instead of copying it. I don't want to mess up my organization more, so I can't really test.

sam-the-enby avatar May 02 '22 21:05 sam-the-enby

right, it might be related to the moving itself, it apparently doesnt happen at copying. Can you confirm?

tibbi avatar May 02 '22 21:05 tibbi

When copying, it does not seem to mangle the modified date

sam-the-enby avatar May 02 '22 21:05 sam-the-enby

This only happens when moving.

J4CKED avatar May 02 '22 21:05 J4CKED

I can confirm this issue on my Android 12 too. Moving picture from Screenshots to Pictures changes its Last modified to 1970, even if Keep old last-modified value at file operations is set. In Simple File Manager, moving works well.

Aga-C avatar May 03 '22 07:05 Aga-C

will be fixed in 6.23.3

tibbi avatar May 03 '22 08:05 tibbi

Great job, I confirm that the bug has been fixed (Android 12)!

J4CKED avatar May 03 '22 11:05 J4CKED

As far as I've tested, can confirm that it is fixed on 12. Thank you!

sam-the-enby avatar May 03 '22 13:05 sam-the-enby

I noticed another bug. Instead of copying photos it moves them. Android 12.

J4CKED avatar May 04 '22 09:05 J4CKED

woops

tibbi avatar May 04 '22 10:05 tibbi

Why is it marked as "fixed" now? Android 11 has a larger market share than 12, which means that this issue still isn't fixed for the majority of affected users.

nbmrjuhneibkr avatar May 04 '22 18:05 nbmrjuhneibkr

because I found no way of fixing it on 11, while 12 is the future and it is close to 11 in the Pro version actually

tibbi avatar May 04 '22 18:05 tibbi

because I found no way of fixing it on 11

This doesn't mean that it's impossible to fix. Especially if we consider that everything worked perfectly fine up until recently. Users will keep encountering this regression, and they will keep submitting it here again and again.

If it really is an insurmountable limitation of Android 11 APIs, then in-app notification should be added for affected users, at the very least.

nbmrjuhneibkr avatar May 08 '22 21:05 nbmrjuhneibkr

sorry i thought i'd already updated (was waiting to be sure wasn't my imagination) but just added to OP as well.

with 6.22.3 (f-droid) running on LOS 11 still, it seems like maybe after a reboot (since it can be a week later sometimes) the file last modification timestamp gets updated, so... 🤷🏽‍♂️

jmichael2497 avatar May 19 '22 23:05 jmichael2497

In Andoid 12, this error still occurs (Keep old last-modified value at file operations). Specifically, it is about modifying a file in the editor. v6.23.10

J4CKED avatar Jun 06 '22 17:06 J4CKED

which editor? The basic foss one from Github, or the advanced one?

tibbi avatar Jun 06 '22 17:06 tibbi

Definitely in the new foss version 6.23.10 and 6.23.9 proprietary.

J4CKED avatar Jun 06 '22 18:06 J4CKED