FixedSizeArrays.jl icon indicating copy to clipboard operation
FixedSizeArrays.jl copied to clipboard

use Base.Test instead of FactCheck

Open SimonDanisch opened this issue 9 years ago • 2 comments

Base.Test is roughly 10x faster because it doesn't create tons of clojures ;)

SimonDanisch avatar Aug 24 '16 16:08 SimonDanisch

Hm, not as fast as promised... FactCheck: 140s Base.Test + testsets: 120s Base.Test - testsets: 60s

Anyone needs testsets!? :D

SimonDanisch avatar Aug 24 '16 17:08 SimonDanisch

@testset is pretty great I'd be sad to loose the grouping.

A while ago I made some of the tests go up to 5x5 matrices to ensure some edge cases were covered, but this definitely made things slower. I think if we want the tests to be faster we could just be more targeted, and cut the matrix tests down to testing a good set of general and edge case NxM shapes, without testing them exhaustively up to a max size.

c42f avatar Aug 25 '16 04:08 c42f