AutoGPT icon indicating copy to clipboard operation
AutoGPT copied to clipboard

feat(platform): Update block UI

Open majdyz opened this issue 1 year ago โ€ข 2 comments

Background

This is the revival of https://github.com/Significant-Gravitas/AutoGPT/pull/8190. With the input-field bug fixed

Changes ๐Ÿ—๏ธ

Update block UI based on the agreed design.

Testing ๐Ÿ”

[!NOTE] Only for the new autogpt platform, currently in autogpt_platform/

  • Create from scratch and execute an agent with at least 3 blocks
  • Import an agent from file upload, and confirm it executes correctly
  • Upload agent to marketplace
  • Import an agent from marketplace and confirm it executes correctly
  • Edit an agent from monitor, and confirm it executes correctly

majdyz avatar Oct 03 '24 22:10 majdyz

PR Reviewer Guide ๐Ÿ”

Here are some key observations to aid the review process:

โฑ๏ธย Estimated effort to review: 3 ๐Ÿ”ต๐Ÿ”ต๐Ÿ”ตโšชโšช
๐Ÿงชย No relevant tests
๐Ÿ”’ย No security concerns identified
โšกย Recommended focus areas for review

Code Complexity
The CustomNode component has become quite complex with multiple nested conditions and components. Consider breaking it down into smaller, more manageable sub-components for better maintainability.

Performance Concern
The component is re-creating the categories array on every render. Consider memoizing this value to improve performance.

Potential Bug
The InputRef function is using a closure to set the input value. This might lead to stale values if the component re-renders. Consider using useRef or controlled inputs instead.

qodo-merge-pro[bot] avatar Oct 03 '24 22:10 qodo-merge-pro[bot]

Deploy Preview for auto-gpt-docs canceled.

Name Link
Latest commit 91c11df84f7a95185008cd528163d2e5b68e4474
Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/670a4016613d830008aeccb2

netlify[bot] avatar Oct 03 '24 22:10 netlify[bot]

Checked API Key is not leaked Screenshot 2024-10-07 at 10 53 24

{
  "id": "ed5d851c-9343-4b9f-bef6-276233301102",
  "version": 1,
  "is_active": true,
  "is_template": false,
  "name": "apitest",
  "description": "Agent Description",
  "executions": null,
  "nodes": [
    {
      "id": "3969861a-9af3-477c-8c05-08f9bff9675e",
      "block_id": "1f292d4a-41a4-4977-9684-7c8d560b9f91",
      "input_default": {},
      "metadata": {
        "position": {
          "x": 608,
          "y": 132.5
        }
      }
    }
  ],
  "links": [],
  "subgraphs": {}
}

Swiftyos avatar Oct 07 '24 08:10 Swiftyos

LGTM - I've run through the tests. Though we can no longer test the marketplace features locally

Swiftyos avatar Oct 07 '24 08:10 Swiftyos

@Swiftyos can you approve it?

majdyz avatar Oct 07 '24 21:10 majdyz

Though we can no longer test the marketplace features locally

why not? you can change the environment variable to not use the cloud one

aarushik93 avatar Oct 08 '24 16:10 aarushik93

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

github-actions[bot] avatar Oct 09 '24 20:10 github-actions[bot]

Conflicts have been resolved! ๐ŸŽ‰ A maintainer will review the pull request shortly.

github-actions[bot] avatar Oct 10 '24 02:10 github-actions[bot]

you need to commit your lock file updates btw

ntindle avatar Oct 10 '24 17:10 ntindle

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

github-actions[bot] avatar Oct 11 '24 14:10 github-actions[bot]

Conflicts have been resolved! ๐ŸŽ‰ A maintainer will review the pull request shortly.

github-actions[bot] avatar Oct 11 '24 16:10 github-actions[bot]