AutoGPT icon indicating copy to clipboard operation
AutoGPT copied to clipboard

Fix issue #753: Add 1/0 as an alternative to y/n for non-english users

Open Francisco-Montanez opened this issue 2 years ago • 7 comments
trafficstars

Background

A user can communicate with Auto-GPT in a language other than English that does not contain the letters y, n. In this case, the user have to change the keyboard layout between simple and text response to English and back. The numbers are (most likely) the same in any layout.

Changes

The addition of 1/0 has been added as alternatives to y/n in the main.py script to allow non-English speaking users to communicate with Auto-GPT more easily.

Documentation

In the main.py script, a comment has been added to explain that 1/0 can be used as an alternative to y/n for non-English speaking users.

Test Plan

To test this functionality, I performed the following steps:

  • Changed the keyboard layout to a language other than English that does not contain the letters y, n.
  • Prompted Auto-GPT for a response that requires a y/n input.
  • Verified that entering 1/0 instead of y/n returned the expected response from Auto-GPT.

As this is a relatively small and straightforward change, no new test cases were added.

PR Quality Checklist

  • [x] My pull request is atomic and focuses on a single change.
  • [x] I have thouroughly tested my changes with multiple different prompts.
  • [x] I have considered potential risks and mitigations for my changes.
  • [x] I have documented my changes clearly and comprehensively.
  • [x] I have not snuck in any "extra" small tweaks changes

Francisco-Montanez avatar Apr 11 '23 03:04 Francisco-Montanez

@Francisco-Montanez There are conflicts now

nponeccop avatar Apr 12 '23 18:04 nponeccop

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

github-actions[bot] avatar Apr 17 '23 15:04 github-actions[bot]

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

github-actions[bot] avatar Apr 21 '23 00:04 github-actions[bot]

Doing a final check whether this is actually necessary..

Pwuts avatar Apr 21 '23 00:04 Pwuts

@Francisco-Montanez can you give an example of a keyboard layout where y/n would be a problem?

Pwuts avatar Apr 21 '23 10:04 Pwuts

I have a suggestion: To move it to the config file. Then anyone can configure these any way they want, but the default is y/n

coditamar avatar Apr 21 '23 11:04 coditamar

@Francisco-Montanez we would love to have some version of this to improve i18n. But instead of adding a hard-coded 1/0 option, please make the y/n configurable in the settings as @coditamar suggests. That way it doesn't cause extra clutter on users' screens, but can still be used by users who really have trouble typing y/n.

Pwuts avatar Apr 23 '23 17:04 Pwuts

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

github-actions[bot] avatar Apr 23 '23 20:04 github-actions[bot]

Closing in favor of #3178

Pwuts avatar Apr 27 '23 18:04 Pwuts