AutoGPT icon indicating copy to clipboard operation
AutoGPT copied to clipboard

Fix call to `plugin.post_planning`

Open Androbin opened this issue 2 years ago • 4 comments

Background

Expected 1 positional argument

Pylance: reportGeneralTypeIssues

Signature

(method) def post_planning(
    self: Self@AutoGPTPluginTemplate,
    response: str
) -> str

Changes

Before

plugin.post_planning(self, assistant_reply_json)

# equivalent to
type(plugin).post_planning(plugin, self, assistant_reply_json)`
                  # types: AutoGPTPluginTemplate, Agent, str

After

plugin.post_planning(assistant_reply_json)

# equivalent to
type(plugin).post_planning(plugin, assistant_reply_json)
                  # types: AutoGPTPluginTemplate, str

Documentation

Test Plan

PR Quality Checklist

  • [x] My pull request is atomic and focuses on a single change.
  • [x] I have thoroughly tested my changes with multiple different prompts.
  • [x] I have considered potential risks and mitigations for my changes.
  • [x] I have documented my changes clearly and comprehensively.
  • [x] I have not snuck in any "extra" small tweaks changes

Androbin avatar Apr 27 '23 16:04 Androbin

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 4, 2023 2:40am

vercel[bot] avatar Apr 27 '23 16:04 vercel[bot]

Codecov Report

Patch and project coverage have no change.

Comparison is base (a48f26c) 60.96% compared to head (c899ac2) 60.96%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3414   +/-   ##
=======================================
  Coverage   60.96%   60.96%           
=======================================
  Files          72       72           
  Lines        3302     3302           
  Branches      542      542           
=======================================
  Hits         2013     2013           
  Misses       1151     1151           
  Partials      138      138           
Impacted Files Coverage Δ
autogpt/agent/agent.py 48.63% <0.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Apr 27 '23 16:04 codecov[bot]

Please fill out the description of the PR

ntindle avatar Apr 29 '23 17:04 ntindle

this looks like a simple fix for a legit bug

bobisme avatar Apr 29 '23 23:04 bobisme