AutoGPT icon indicating copy to clipboard operation
AutoGPT copied to clipboard

Edit start script for checking environment once.

Open liaosunny123 opened this issue 2 years ago • 3 comments

Background

#2901 , reducing the start time.

Changes

Modifying the run.bat and run.sh. I add the command to generate a file named env_check.lock to skip the env check after first starting.

Documentation

As what the changes said.

Test Plan

I tested in window and ubuntu 22.04, it works.

PR Quality Checklist

  • [√] My pull request is atomic and focuses on a single change.
  • [√] I have thoroughly tested my changes with multiple different prompts.
  • [√] I have considered potential risks and mitigations for my changes.
  • [√] I have documented my changes clearly and comprehensively.
  • [√] I have not snuck in any "extra" small tweaks changes

liaosunny123 avatar Apr 22 '23 14:04 liaosunny123

The script is intended to run the check requirements every time in case the repository was pulled by the user and there are new requirements added, so a one time lock file is not enough.

A better solution would be to check if the requirements file has been not changed since a successful pip install.

hdkiller avatar Apr 23 '23 20:04 hdkiller

The script is intended to run the check requirements every time in case the repository was pulled by the user and there are new requirements added, so a one time lock file is not enough.

A better solution would be to check if the requirements file has been not changed since a successful pip install.

You are right and I ignore this situation. I check check_requirements.py and I think it is unnecessary to get the missing package exactly. Do you think check the hash of the requirment file to decide whether install requirement is a good idea?

liaosunny123 avatar Apr 24 '23 00:04 liaosunny123

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

github-actions[bot] avatar May 04 '23 17:05 github-actions[bot]

This is a mass message from the AutoGPT core team. Our apologies for the ongoing delay in processing PRs. This is because we are re-architecting the AutoGPT core!

For more details (and for infor on joining our Discord), please refer to: https://github.com/Significant-Gravitas/Auto-GPT/wiki/Architecting

p-i- avatar May 05 '23 00:05 p-i-

A hash would work well in this case I believe as we typically pin versions of something breaks relating to a package

ntindle avatar May 18 '23 06:05 ntindle

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview May 20, 2023 2:06am

vercel[bot] avatar May 20 '23 00:05 vercel[bot]

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

github-actions[bot] avatar May 20 '23 00:05 github-actions[bot]

Codecov Report

Patch and project coverage have no change.

Comparison is base (7e21f38) 63.26% compared to head (a29c5b9) 63.26%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2924   +/-   ##
=======================================
  Coverage   63.26%   63.26%           
=======================================
  Files          74       74           
  Lines        3427     3427           
  Branches      504      504           
=======================================
  Hits         2168     2168           
  Misses       1103     1103           
  Partials      156      156           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar May 20 '23 01:05 codecov[bot]

this pr will check requirement.py hash to decide if need to procee

liaosunny123 avatar May 20 '23 01:05 liaosunny123

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

github-actions[bot] avatar Sep 06 '23 15:09 github-actions[bot]