AutoGPT icon indicating copy to clipboard operation
AutoGPT copied to clipboard

Removed baked-in twitter functionality.

Open johnseth97 opened this issue 2 years ago • 5 comments

Background

Twitter functionality is now included in the plugins repository. The inclusion of a send_tweet command confuses Auto-GPT and takes up tokens. Any future PRs related to twitter should be directed there.

Changes

Removed baked-in twitter functionality.

Documentation

Self documenting 😉

Test Plan

Ran it and it didn't break.

PR Quality Checklist

  • [ x] My pull request is atomic and focuses on a single change.
  • [ x] I have thoroughly tested my changes with multiple different prompts.
  • [ x] I have considered potential risks and mitigations for my changes.
  • [ x] I have documented my changes clearly and comprehensively.
  • [ x] I have not snuck in any "extra" small tweaks changes

johnseth97 avatar Apr 21 '23 07:04 johnseth97

@BillSchumacher LGTM

hdkiller avatar Apr 21 '23 09:04 hdkiller

This is a breaking change and should not be merged without advance notice to users.

Pwuts avatar Apr 21 '23 10:04 Pwuts

What about using the existing News functionality to announce changes like this?

hdkiller avatar Apr 21 '23 10:04 hdkiller

This is a breaking change and should not be merged without advance notice to users.

It should probably be discussed in the next meeting, along with a guideline for removing any other baked in commands that are to be replaced by plugins.

The real issue with leaving things in that can be covered by plugins is that the duplicate functionality allows more opportunities for Auto-GPT to become confused, as well as wasting tokens. At least, as far as I understand it. Feel free to correct me if I'm wrong.

johnseth97 avatar Apr 21 '23 18:04 johnseth97

Would like to also do all the plugin scaffolding and move at once. @desojo would you want to help move all the plugins?

ntindle avatar Apr 22 '23 06:04 ntindle

I noticed the files have been removed, anything to do with this PR?

If you still need help moving plugins out of Auto-GPT core I can assist with that as well

johnseth97 avatar Apr 23 '23 21:04 johnseth97

Yeah hop in the plugins chat on discord

ntindle avatar Apr 23 '23 21:04 ntindle

Codecov Report

Patch coverage has no change and project coverage change: +0.25 :tada:

Comparison is base (f04755b) 36.25% compared to head (a0b0ec7) 36.51%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2786      +/-   ##
==========================================
+ Coverage   36.25%   36.51%   +0.25%     
==========================================
  Files          60       59       -1     
  Lines        2849     2829      -20     
  Branches      471      470       -1     
==========================================
  Hits         1033     1033              
+ Misses       1754     1734      -20     
  Partials       62       62              
Impacted Files Coverage Δ
autogpt/cli.py 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Apr 23 '23 21:04 codecov[bot]

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

github-actions[bot] avatar Apr 24 '23 19:04 github-actions[bot]