Auto-GPT-Plugins icon indicating copy to clipboard operation
Auto-GPT-Plugins copied to clipboard

Fix encoding issues when reading emails using the email plugin

Open sdelgadoc opened this issue 2 years ago • 2 comments

Fix encoding issues when reading emails in the email plugin

  • Identify encoding problems in email subject and body text
  • Handle encoding issues elegantly if they are found
  • Added comments to highlight functionality added

The previous version of the email plugin was encountering encoding errors when reading emails, as documented in the following issues (https://github.com/Significant-Gravitas/Auto-GPT-Plugins/issues/104, https://github.com/Significant-Gravitas/Auto-GPT-Plugins/issues/110). This PR attempts to resolve as many of the encoding issues as I was able to identify.

sdelgadoc avatar May 11 '23 19:05 sdelgadoc

Thanks! Can you add a matching test?

ntindle avatar May 12 '23 06:05 ntindle

Codecov Report

Patch coverage has no change and project coverage change: -0.18 :warning:

Comparison is base (57d9213) 67.21% compared to head (8114a4f) 67.04%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #139      +/-   ##
==========================================
- Coverage   67.21%   67.04%   -0.18%     
==========================================
  Files          21       27       +6     
  Lines        1458     1681     +223     
  Branches      180      188       +8     
==========================================
+ Hits          980     1127     +147     
- Misses        462      534      +72     
- Partials       16       20       +4     

see 6 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar May 12 '23 06:05 codecov[bot]

Add tests

Added tests per request from @ntindle

sdelgadoc avatar May 13 '23 21:05 sdelgadoc