hostd icon indicating copy to clipboard operation
hostd copied to clipboard

Config change advises to re-announce without hostname change

Open timrettop opened this issue 10 months ago • 0 comments

Current Behavior

I changed a couple settings and selected Save, the settings did not include a change to the hostname. Selecting Save after any changes (not including the hostname) results in the success message advising to Re-announce.

Image

Expected Behavior

Success message indicating to Re-Announce only displays if an announcement is required.

Steps to Reproduce

No response

Version

v2.0.2

What operating system did the problem occur on (e.g. Ubuntu 22.04, macOS 12.0, Windows 11)?

ubuntu host - docker container

Anything else?

It looks like the host state shows the lastAnnouncement.address as hostname:port which does not match with the input of hostname only as the form requires. https://github.com/SiaFoundation/web/blob/d8588a197781d028206ca46a32282d4ab0653061/apps/hostd/components/Config/AnnounceButton.tsx#L33

Maybe it would be good to display the port in the form anyways so users that have to use non-default ports are aware that its configured as they expect.

timrettop avatar Jan 19 '25 23:01 timrettop