pinning prices uses USD regardless of selected fiat currency

[npelov]

Current Behavior

When currency is set to eur and price is pinned usd sign is shown. I believe USD rate is also used (not just the sign)

Expected Behavior

when fiat is set to EUR in configuration pinning sound be tied to selected currency (IMHO)

Steps to Reproduce

1. click app preferences icon
2. set fiat to EUR
3. go to configuration
4. the currency is EUR as it should be
5. pin storage price
6. the currency is now USD for storage price

Version

v1.1.2

What operating system did the problem occur on (e.g. Ubuntu 22.04, macOS 12.0, Windows 11)?

docker on Debian 12

Anything else?

[n8mgr]

You currently change the pinning currency separately from the UI currency.

@alexfreska do you think there's an easy way to unify this in the UI? Would it be best bite the bullet and make an API change?

[npelov]

oh. didn't notice that. Thanks

[alexfreska]

I agree that the separate pinned currency is confusing, I kept it this way because even if we were to set the pinning currency (server-side setting) to the current currency display preference (client-side setting), technically someone could change the pinned currency on a different client or through the API and put them out of sync. We could add a dedicated global currency setting to the daemons to use for both display and pinning, but then the user cannot play around with the display currency without affecting their pricing or two users/clients cannot use different display currencies, ie: user B likes to view host pricing in JPY, but selecting this would change the actual underlying siacoin pricing value.

Maybe an improvement would be simply moving the pinned currency setting out of the configuration page and into the app preferences panel next to the display currency.

• This way users will more easily notice and associate the 2 currency settings when going into the app preferences.
• Still having two settings means clients will not have a "sync" problem.
• All clients can select their own display currency without affecting the real pinned price.
• We could add a warning/info message explaining the two settings below pinned fields when the client's display currency is != the pinned currency.