SiEPIC_EBeam_PDK
SiEPIC_EBeam_PDK copied to clipboard
strip-to-slot: center pins around y=0
Slight changes to geometry to make the cell symmetric around y. makes things a lot easier for connect_cell transformations...
Before:
After:
Codecov Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 73.33%. Comparing base (dfca8a4) to head (b24db10).
Additional details and impacted files
@@ Coverage Diff @@
## master #323 +/- ##
=======================================
Coverage 73.33% 73.33%
=======================================
Files 105 105
Lines 12730 12730
=======================================
Hits 9336 9336
Misses 3394 3394
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
Any simulations on the insertion loss? How do the two cells compare?
@mustafacc ?
I don't think they'd be any different, other than the direction of the waveguides; but in any case I simulated both
pre-commit
post-commit
One possibility is that the slot waveguide loss will be higher for the diagonal design, due to the quantization of the EBL. It may be interesting to compare and see if there is a difference.
Given that it is a relatively large change to the design, my suggestion is to have two separate cells, rather than modifying the existing one.
e.g., strip-to-slot, strip-to-slot-v2.
@mustafacc could you make two versions?
thanks