MCCoroutine icon indicating copy to clipboard operation
MCCoroutine copied to clipboard

Deadlock when joining a job switching context to minecraft scope while plugin is disabled

Open Shynixn opened this issue 3 years ago • 2 comments

Notes:

  • Only occurs when you try to join a job using runBlocking in onDisable.
  • Looking for hacktoberfest contributors.

How to fix:

  • Add a plugin.isEnabled check to isDispatchNeeded in com.github.shynixn.mccoroutine.bukkit.dispatcher.MinecraftCoroutineDispatcher and com.github.shynixn.mccoroutine.bukkit.dispatcher.AsyncCoroutineDispatcher
  • Remove if (!plugin.isEnabled) check in dispatch from those files

Shynixn avatar Oct 07 '22 16:10 Shynixn

Can I work on this?

Jupiops avatar Oct 09 '22 08:10 Jupiops

Sure

Shynixn avatar Oct 09 '22 22:10 Shynixn