Lukas Kurz

Results 64 comments of Lukas Kurz

I've temporarily switched the default branch of my fork so you can preview how those templates would look like. https://github.com/ShortDevelopment/ChakraCore/issues/new/choose

https://github.com/chakra-core/ChakraCore/blob/2af598f04ab508f9231d6e26f0f82f5a57561413/lib/Backend/IR.cpp#L4852

I'm currently working on function calls. At the moment it would just be handled as if no optional-chaining would be used ⇾ crash in js land _Edit:_ Function call should...

The jitted code currently crashes at this assertion (causing the test-failures) https://github.com/chakra-core/ChakraCore/blob/1f6e17c4c55231846596223eab8ab36360349fa3/lib/Backend/GlobOpt.cpp#L11384

There are still [some projects](https://github.com/search?q=https%3A%2F%2Faka.ms%2Fchakracore%2F&type=code) using the legacy download structure. We could download the binaries and attach them directly to the GitHub Releases. (Including a deprecation warning)

Only the last 2 seem to be still available

Seems like V8 terminates a `for..in` loop if the prototype changes; CC doesn't. ```js const obj = { "obj_prop": "value" }; const arrayPrototype = ["some_item", "some_item2"]; Object.setPrototypeOf(obj, arrayPrototype); let counter...

According to the [spec](https://tc39.es/ecma262/#sec-enumerate-object-properties) this might actually be valid behavior! > [...] the iterator must behave as would the iterator given by [CreateForInIterator](https://tc39.es/ecma262/#sec-createforiniterator)(O) until one of the following occurs: >...

@rhuanjl Comparing the CI output of a PR with "no code" and mine it seems like the failing tests might be unrelated to the changes in this PR - https://cirrus-ci.com/task/6543904518963200...

@rhuanjl Comments are removed > Seems you were right, CI is sorted now It's still a bit scary to have CI failing randomly