LiveSplit.HollowKnight icon indicating copy to clipboard operation
LiveSplit.HollowKnight copied to clipboard

Updated splits from @mayonnaisical

Open AlexKnauth opened this issue 11 months ago • 1 comments
trafficstars

An updated version of https://github.com/slaurent22/LiveSplit.HollowKnight/pull/27 to resolve merge conflicts.

  • [x] Address review comments that have been made on Discord (Mostly done)
  • [x] Add start trigger separator: https://github.com/mayonnaisical/LiveSplit.HollowKnight/pull/6
  • [x] Transition excluding discontinuities (savestate, death, dreamgate)
  • [x] door_dreamReturn is a discontinuity
  • [x] Address TODOs left in the code
  • [x] Test changes
    • [x] Make sure 1028 Modded still works
    • [x] Start New Game: normal, steel soul, godseeker
    • [x] Start Pantheon: Pantheon 1-5, first-time cutscene, subsequent no-cutscene
    • [x] Ending A-E and RadianceP: only on their respective endings
    • [x] Menu splits: don't split on menu after condition was true but becomes false
    • [x] Soul Sanctum Hallownest Seal
    • [x] Stag Position Updated
    • [x] City Toll Bench Room Transition
    • [x] Transition excluding discontinuities: don't split on savestate, death, or dreamgate, including Godhome dreamgate-out
    • [x] Has Shade Soul Transition: make sure it still works as expected in normal NMG play; idk how to do room dupes
      • with some delay in real time, though no difference in loadless time
    • [x] Enter Troupe Master Grimm: don't split when Grimmchild isn't equipped
    • [x] Pure Snail: split on full focus at full health
    • [x] Test savestates in Monomon dream for Transition excluding savestate and Transition excluding discontinuities
  • [x] Version and changelog update with credit to Mayo and Python
  • [x] Build release dll last

AlexKnauth avatar Dec 02 '24 07:12 AlexKnauth

Converting this to a draft for now. I will need to do one last rebase and dll build after the smaller PRs are merged, before this can be ready.

AlexKnauth avatar Jan 14 '25 05:01 AlexKnauth