Q-Optimality-Tightening icon indicating copy to clipboard operation
Q-Optimality-Tightening copied to clipboard

Question about quadratic penalties

Open KaraLuo opened this issue 7 years ago • 2 comments

@ShibiHe Hi, thanks for your great paper, and sorry to bother you.

In the paper, the upper bound and lower bound are incorporated into the algorithm via quadratic penalties. But I cannot find the implementation corresponding to these two quadratic penalties.

It seems that the loss function is defined in the init function of DeepQLearner class. Here no penalties are added.

And some main differences comparing with the original DQN codes are shown in _do_training function of OptimalityTightening class. I am not so sure what is the meaning of targets1 variable. And how can this implementation works as two quadratic penalties in paper?

Please correct me if I'm wrong, and thank you very much!!

KaraLuo avatar Dec 08 '17 06:12 KaraLuo

Hi, please refer to Explain part in the readme for details.

ShibiHe avatar Dec 08 '17 20:12 ShibiHe

Thank you very much! Apologize for missing it... But I still don't know the reason to do so. Will this be convenient for implementation?

Thank you again! Very appreciate!

KaraLuo avatar Dec 15 '17 08:12 KaraLuo