rnnoise_python icon indicating copy to clipboard operation
rnnoise_python copied to clipboard

update rnnoise_create signature

Open mihai3 opened this issue 2 years ago • 1 comments

rnnoise_create requires a parameter since https://github.com/xiph/rnnoise/commit/231b9c02d14a74cb449a98004cb7a2cf1bdeca2f. The parameter denotes the model to use; NULL can be used as default.

If this parameter is not added, mysterious segfaults occur: https://github.com/xiph/rnnoise/issues/69#issuecomment-498477189

Example:

0x00007fffec1308de in compute_dense (layer=0x0, output=output@entry=0x7fffffff3c90, input=input@entry=0x7fffffff4cd0) at src/rnn.c:85

mihai3 avatar Jan 05 '23 23:01 mihai3

Adding None as argument to the rnnoise_create method solves the Segmentation fault problem. Great tip!

csana23 avatar Feb 05 '23 18:02 csana23