Shannon Deminick

Results 341 comments of Shannon Deminick

Awesome! All looks good, i just added one question on the PR for you

Potentially we need to adjust the compression level here https://github.com/Shazwazza/Smidge/blob/b0383c3b7e2b667402451dcff7055209ceabd428/src/Smidge.Core/CompositeFiles/Compressor.cs#L30 I was just reading about compression on dynamic resources here https://expeditedsecurity.com/blog/nginx-brotli/ And looks like the different levels of compression will...

Sounds reasonable. But I wonder based on what @nikolajlauridsen says, if these would need to be configurable per bundle? Just like the cache buster is configurable per bundle. i.e. Global...

Creating dynamic bundles in partial views is problematic for various reasons: * If any partial view is cached, it breaks * If you want to use progressive rendering, it breaks...

My advice is to pre-define your bundles and render them where necessary instead of trying to rely on what is in a page to determine what script to load. If...

> we add the js files within views and partial views based on smidgeHelper.RequiresJs. In ClientDependency you could use RequiresJs and the ordering number of the assets directly in the...

@deekoulos in your example you are adding to the bundle in your view - which as I mention will not work because you don't know when your view is executing...

Putting quotes in a query means that it will be treated as a Phrase query and wildcards are not supported in Phrase queries.

Closing this since it's just not worth doing this

@nikcio Sorry to keep you waiting on this one, I have all of these starred in my inbox and will get to them soon, just a bit swamped this week.