Smidge icon indicating copy to clipboard operation
Smidge copied to clipboard

Change single quotes to double quotes in HTML output

Open craigs100 opened this issue 3 years ago • 3 comments

Just noticed the Smidge output uses single quotes in HTML rather than double.

I know both are technically legal but I also know that many people use double quotes in HTML and single quotes in JS. Any chance they could be changed? So this: <link href='/sc/69a3dbf6.1cf661e7.css.v100' rel='stylesheet' type='text/css'/> becomes this: <link href="/sc/69a3dbf6.1cf661e7.css.v100" rel="stylesheet" type="text/css"> (note the forward slash is also removed as it's no longer necessary in HTML5 AFAIK. You could probably remove the "type" attribute as well).

Thnx

craigs100 avatar Dec 31 '21 14:12 craigs100

Hi @craigs100 ! That can be done :) It would be super awesome if you'd be able to submit a PR with the change and then I can get another release out once it's merged. Do you think you'd be able to help?

Shazwazza avatar Jan 01 '22 06:01 Shazwazza

PR submitted but not tested ( I don't have the chops for that ;) )

craigs100 avatar Jan 01 '22 12:01 craigs100

Awesome! All looks good, i just added one question on the PR for you

Shazwazza avatar Jan 12 '22 21:01 Shazwazza