ClientDependency icon indicating copy to clipboard operation
ClientDependency copied to clipboard

Possibility to preserve important comment?

Open 686d7066 opened this issue 11 years ago • 2 comments
trafficstars

Hi,

I am currently working with Umbraco 7 and since this comes pre-configured with the Client Dependency framework it was natural to use this for bundling and minifiying javascript files. However, in contrast to other minifiers I´ve worked with, DP removes comments marked as important with an exclamation mark. For example the license information for jQuery: /*! jQuery v1.11.0 | (c) 2005, 2014 jQuery Foundation, Inc. | jquery.org/license */

Comments of this type are most of the time copyright and license information and these have to be included when using such plugins in production.

I havent found a way to preserve such comments with DP. Did I miss a config-value or is this not possible?

686d7066 avatar Jun 12 '14 19:06 686d7066

Hi, I can create an option for this, currently there is no option to enable this.

Shazwazza avatar Jun 17 '14 04:06 Shazwazza

Because CDF works at runtime you would not be shipping the CDF minified content in your source code which is where the copyright information would live, I don't think there's a legal requirement to keep these comments in the code that is served over http for your website (though I could be wrong). In any case, I can enable this in next release.

Shazwazza avatar Jun 17 '14 04:06 Shazwazza