ClientDependency icon indicating copy to clipboard operation
ClientDependency copied to clipboard

RenderJsBundleHere & RenderCssBundleHere #1

Open giuunit opened this issue 9 years ago • 2 comments
trafficstars

Multiple commits due to error in the name of the commit at first attempt.

giuunit avatar Sep 26 '16 13:09 giuunit

Thanks for the PR!

This will be a little more complex than this unfortunately. The method you are calling in to to render the Js is this one: https://github.com/Shazwazza/ClientDependency/blob/master/ClientDependency.Mvc/HtmlHelperExtensions.cs#L267

Which isn't used to render a bundle, that is used to render any dependencies registered for that file type based on a defined provider (renderer). The code you've applied essentially makes the whole page dependent on a bundle and then tries to render out html tags based on a specific provider.

Instead it needs to just render out the tags for the particular bundle, not adding any dependencies, etc... I haven't looked into this codebase for quite a while, i can get back to you soon with some info on how to generate these URLs

Shazwazza avatar Sep 28 '16 06:09 Shazwazza

Oh, my bad

I will have a look on my side me too

giuunit avatar Sep 28 '16 09:09 giuunit