Articulate icon indicating copy to clipboard operation
Articulate copied to clipboard

#361 - Update GitHub action build to use UmbPack

Open mbogunovic opened this issue 4 years ago • 2 comments
trafficstars

  • Removal of createdPackages.config and packageManifest.xml in favor of package.xml (umbPack default package configuration file)
  • Update of build.yml to use umbPack
  • update of build.ps1 to use umbPack

TODO: Discuss the deployment part if it is going to replace the actions/upload-artifact@v2 with umbpack push

NOTE: This is just initial deployment, please test thoroughly and leave a comment what needs to be updated. Build steps should remain the same.

Possible issues:

  • noticed that the built zip file with umbPack does not contain random guid for all files like the build before contained (but the number of files is the same). Additional configuration may be needed.
  • removal of createdPackages.config and packageManifest.xml is a critical change, please check for additional references (maybe I've missed something)

mbogunovic avatar Jun 04 '21 08:06 mbogunovic

@Shazwazza Ready for initial review

mbogunovic avatar Jun 04 '21 08:06 mbogunovic

@Shazwazza Ready for initial review

@Shazwazza

Updated the package files path, build steps: 9. Open a powershell command line at the /build folder 10. Execute build.ps1

Need to be updated to: 9. Open a powershell command line at the root of the repository 10. Run command ./build/build.ps1

mbogunovic avatar Jun 04 '21 09:06 mbogunovic

Appreciate all the effort here! But with Articulate 5 this is no longer necessary. For any patch release work for previous versions we can just keep the build as-is.

Shazwazza avatar Apr 06 '23 14:04 Shazwazza