sp-dev-docs icon indicating copy to clipboard operation
sp-dev-docs copied to clipboard

SharePoint webpart settings are reset when editing tab in new MS Teams clients

Open xxyziggy opened this issue 1 year ago • 15 comments

Target SharePoint environment

SharePoint Online

What SharePoint development model, framework, SDK or API is this about?

💥 SharePoint Framework

Developer environment

None

What browser(s) / client(s) have you tested

  • [ ] 💥 Internet Explorer
  • [X] 💥 Microsoft Edge
  • [X] 💥 Google Chrome
  • [ ] 💥 FireFox
  • [ ] 💥 Safari
  • [ ] mobile (iOS/iPadOS)
  • [ ] mobile (Android)
  • [ ] not applicable
  • [X] other (enter in the "Additional environment details" area below)

Additional environment details

Microsoft Teams Desktop Client: Microsoft Teams version: 23320.3027.2591.1505 Client version: 49/23113028722 Last updated: 16.01.2024 Operating System: Windows 11

Microsoft Teams Web Client: Microsoft Teams version: Client version: 415/23113028722

Describe the bug / error

SharePoint webpart settings in MS Teams tab are reset when editing tab in new MS Teams clients

Steps to reproduce

  1. Create a Teams app with SharePoint webpart in it, webpart must have configurable properties
  2. In app manifest use
 "configurableTabs": [
        {
            "canUpdateConfiguration": true,
            "configurationUrl": "https://{teamSiteDomain}{teamSitePath}/_layouts/15/TeamsLogon.aspx?SPFX=true&dest={teamSitePath}/_layouts/15/teamshostedapp.aspx%3FopenPropertyPane=true%26teams%26componentId={{SPFX_COMPONENT_ID}}%26forceLocale={locale}",
            "scopes": ["team"],
            "context": ["channelTab"]
        }
    ],
  1. Publish the app, and create a Tab in MS Teams with this webpart and confugure its properties
  2. Click Tab settings
  3. Popup opens, after clicking Save button webpart props panel is opened, but properties are empty and webpart state goe back to unconfigured state

new teams

Expected behavior

In old teams clients after clicking Tab settins no popup appears, webpart configuration panel opens with saved properties old teams

xxyziggy avatar Jan 16 '24 16:01 xxyziggy

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

ghost avatar Jan 16 '24 16:01 ghost

This issue is also occurring in my environment with custom SPFx web part. The correct experience is functioning in the old Microsoft Teams desktop app.

ruiAfonsoISEP avatar Feb 23 '24 12:02 ruiAfonsoISEP

I observe the same behavior, settings in teams get lost on a roundtrip.

UeliSchwarz avatar Mar 15 '24 09:03 UeliSchwarz

We experience the same bug in Teams (NEW). SPFx properties are reset every time we open settings.

antonkhrit avatar May 02 '24 10:05 antonkhrit

Just had several very unhappy customers reporting that all their settings got lost when they try to edit the tab properties. There used to be an "edit" button, now there is only "settings" and it opens a popup and deletes all properties.

Any updates on this?

shaipetel avatar May 08 '24 14:05 shaipetel

I think this is a duplicate of this issue 9389

shaipetel avatar May 20 '24 19:05 shaipetel

Hi,

we have facing the same issue in New Teams. Any update?

FYI : we have upgraded the solution to SPFx 1.18.2.

Already reported here as well https://github.com/SharePoint/sp-dev-docs/issues/9389

kandharithirumalreddy avatar May 21 '24 01:05 kandharithirumalreddy

I agree that this is a very annoying bug that makes SPFX web parts unusable as Teams Tabs.

But I don't agree with the described expected behavior. I would prefer that the behavior was that when adding/updating the tab, the following should happen:

  1. The dialog should appear, but with the property pane instead of just a Teams logo
  2. When save was clicked then settings was saved to HostedAppConfigs and dialog dismissed
  3. Then the tab should load webpart with specified properties and no property pane.

singingknight avatar May 23 '24 10:05 singingknight

I agree that this is a very annoying bug that makes SPFX web parts unusable as Teams Tabs.

But I don't agree with the described expected behavior. I would prefer that the behavior was that when adding/updating the tab, the following should happen:

  1. The dialog should appear, but with the property pane instead of just a Teams logo
  2. When save was clicked then settings was saved to HostedAppConfigs and dialog dismissed
  3. Then the tab should load webpart with specified properties and no property pane.

I don't think this is an acceptable behavior for all web parts.

The side panel did not block access to the web part while editing properties, and a Dialog blocks access.

Many web parts have inline-editing and WYSIWYG editing, not just using the properties panel, so if you block access in a dialog that would not be possible.

Even a simple image viewer or rich text editor web part won't work as people won't be able to type in the web part while it is in edit mode.

shaipetel avatar May 23 '24 14:05 shaipetel

Hi,

any update on this issue, when will it be fixed? will the fix be part of next release?

Now Microsoft forcing to use New Teams. So it's effecting our customers. Now It's become major issue for us.

kandharithirumalreddy avatar May 24 '24 05:05 kandharithirumalreddy

Hi,

any update on this issue, when will it be fixed? will the fix be part of next release?

Now Microsoft forcing to use New Teams. So it's effecting our customers. Now It's become major issue for us

kandharithirumalreddy avatar Jun 11 '24 11:06 kandharithirumalreddy

Hi,

any update on this issue, when will it be fixed? will the fix be part of next release?

Now Microsoft forcing to use New Teams. So it's effecting our customers. Now It's become major issue for us.

It's strange that no updates from the assigned persons

kandharithirumalreddy avatar Jun 21 '24 08:06 kandharithirumalreddy

Hi,

any update on this issue, when will it be fixed? will the fix be part of next release?

Now Microsoft forcing to use New Teams. So it's effecting our customers. Now It's become major issue for us

It strange that why they are unable to fix this issue. The issue is this always they are creating a new Instance for the webpart properties, instead if the maintain some kind of ID/TabUrl/WebpartInstanceId then it will update if already added.

kandharithirumalreddy avatar Jun 26 '24 10:06 kandharithirumalreddy

Sorry for the long delay folks. We have identified the issue and will be working with Microsoft Teams partners to fix it. Will update the thread when we have rollout ETA or other updates.

AJIXuMuK avatar Jul 03 '24 18:07 AJIXuMuK

Thank you for the update, @AJIXuMuK

PMcGown avatar Jul 03 '24 18:07 PMcGown

Thank you, @AJIXuMuK ! We (and our customers) will look forward to this fix! For us, it's especially impacting our Social Squared discussion board app, because many of our clients use it in Teams in addition to SharePoint, and Team Owners use the Settings panel for a lot of configuration.

SandyLT avatar Jul 08 '24 17:07 SandyLT

So the issue is being worked on. We are expecting the fix to be rolled out globally by mid August. Than you everyone for the patience and sorry once again for a long delay!

AJIXuMuK avatar Jul 09 '24 20:07 AJIXuMuK

Thanks for the update, @AJIXuMuK . We appreciate you prioritizing this issue.

PMcGown avatar Jul 09 '24 20:07 PMcGown

Hi @AJIXuMuK

Any update on this fix to be rolled ?

Thanks Thirumal Reddy

kandharithirumalreddy avatar Aug 12 '24 13:08 kandharithirumalreddy

@kandharithirumalreddy - one of the fixes has rolled out but it is still working not ideally. We're working on additional fixes.

Good thing is - the properties are not reset anymore. Bad thing - settings pane is not always opening.

You may need to reload a tab multiple times to open the pane. See the video:

https://github.com/user-attachments/assets/26e7f69c-a3e3-47e6-bf34-03882c025038

AJIXuMuK avatar Aug 20 '24 16:08 AJIXuMuK

Thanks for the update, @AJIXuMuK

PMcGown avatar Aug 20 '24 17:08 PMcGown

Hi @AJIXuMuK

That's great.

Thank you very much for your update.

We will try to test internally.

Thanks Thirumal Reddy

kandharithirumalreddy avatar Aug 20 '24 17:08 kandharithirumalreddy

Hello @xxyziggy, Thank you for bringing this issue to our attention. Could you please confirm if the issue still persists for you?

Amey-MSFT avatar Jul 07 '25 10:07 Amey-MSFT

@Amey-MSFT it's working now, thanks for the update!

xxyziggy avatar Jul 07 '25 12:07 xxyziggy