sp-dev-docs icon indicating copy to clipboard operation
sp-dev-docs copied to clipboard

ApplyTheme: neutralLighter / second section color does not change

Open emilyTeichrib opened this issue 3 years ago • 6 comments

Target SharePoint environment

SharePoint Online

What SharePoint development model, framework, SDK or API is this about?

not applicable

Developer environment

No response

What browser(s) / client(s) have you tested

  • [ ] 💥 Internet Explorer
  • [ ] 💥 Microsoft Edge
  • [X] 💥 Google Chrome
  • [ ] 💥 FireFox
  • [ ] 💥 Safari
  • [ ] mobile (iOS/iPadOS)
  • [ ] mobile (Android)
  • [ ] not applicable
  • [ ] other (enter in the "Additional environment details" area below)

Additional environment details

  • browser version
  • SPFx version
  • Node.js version
  • etc

Describe the bug / error

Previously, when I applied a theme that I created with Theme Designer (https://fluentuipr.z22.web.core.windows.net/heads/master/theming-designer/index.html), it also allowed me to change the second section color. For the second section color the color "neutralLighter" from the theme is used as far as I know (until now it was always like this). We use different tenants and on those, where always directly the new releases are applied, this color is no longer loaded from my self-defined theme, but a standard light gray is used. On the other tenants it still works correctly. Is this a bug that will hopefully be fixed as soon as possible or have things fundamentally changed here?

Steps to reproduce

  1. Apply a custom theme with the endpoint "/_api/ThemeManager/ApplyTheme"
  2. Check the second section background color, if it has the color of "neutralLighter" in the theme definition.

Expected behavior

The second section background color has the color that is defined as "neutralLighter" in the custom Theme.

emilyTeichrib avatar Aug 15 '22 11:08 emilyTeichrib

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

ghost avatar Aug 15 '22 11:08 ghost

We are also seeing this issue on multiple tenants. The issue is not the theme not setting (the colors are set correctly if you check with powershell) but they are not rendering correctly. It looks like MS is just ignoring some of the theme colors like "neutralLighter " and using default gray values.

tomvr2610 avatar Aug 19 '22 08:08 tomvr2610

I also noticed this issue. Colors are set correctly when requesting them through the API but something is going wrong before/during/after loading the page where some colors like 'neutralLighter' are reset to some default values like '#F0F0F0'.

Did some testing and created a new theme using the steps described here but the issue persists.

The issue is now also starting to pop up with some of our customers so it'd be great if this could be resolved quickly before we start receiving more reports and angry emails of why the colors are all wrong.

Thanks in advance!

DmitriyVdE avatar Aug 19 '22 08:08 DmitriyVdE

@emilyTeichrib @tomvr2610 @DmitriyVdE - thank you for your comments. We've got the lead why it's happening and will be working on it.

AJIXuMuK avatar Aug 19 '22 21:08 AJIXuMuK

Seems to be fixed since today.

DmitriyVdE avatar Aug 26 '22 07:08 DmitriyVdE

@emilyTeichrib - could you also confirm this is fixed?

AJIXuMuK avatar Oct 12 '22 15:10 AJIXuMuK

This issue has been automatically marked as stale because it has marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within the next 7 days of this comment. Please see our wiki for more information: Issue List Labels: Needs Author Feedback & Issue List: No response from the original issue author

ghost avatar Oct 19 '22 18:10 ghost

Closing issue due to no response from the original author. Please refer to our wiki for more details, including how to remediate this action if you feel this was done prematurely or in error: No response from the original issue author

ghost avatar Oct 26 '22 22:10 ghost