Extension
Extension copied to clipboard
fix: ignore composing key events to prevent unintended behavior
Proposed changes
This change fixes an issue where history navigation (up/down arrow key on chat box) was accidentally triggered during IME composition.
Types of changes
What types of changes does your code introduce to 7TV?
Put an x in the boxes that apply
- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
- [x] I have read the CONTRIBUTING doc
- [x] Lint and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] I have added necessary documentation (if appropriate)
- [ ] Any dependent changes have been merged and published in downstream modules
Further comments
IME is a tool for writing Japanese (and other languages I'm not aware of) where users can select the word they want to enter from the list of words that match the pronounciation given by the user's keystrokes--this process is called composition. It's pretty common to press arrow key during composition, and that has caused unintended chat history rewinding:
-
Opens up IME
-
After pressing UP