serenity icon indicating copy to clipboard operation
serenity copied to clipboard

nix: clean up files, use good practices

Open RGBCube opened this issue 1 year ago • 3 comments

  • nix: clean up files
  • nix: update docs to reflect the new setup

RGBCube avatar Mar 16 '24 08:03 RGBCube

Hello!

One or more of the commit messages in this PR do not match the SerenityOS code submission policy, please check the lint_commits CI job for more details on which commits were flagged and why. Please do not close this PR and open another, instead modify your commit message(s) with git commit --amend and force push those changes to update this PR.

BuggieBot avatar Mar 16 '24 08:03 BuggieBot

I also moved the new nix command to the top, as it should be preferred.

RGBCube avatar Mar 16 '24 08:03 RGBCube

Should be good to go then, I've applied the changes requested.

RGBCube avatar Mar 18 '24 07:03 RGBCube

hm I don't like how we're declaring this as "good practice" that are in fact (in practice) considered experimental in Nix. The previous description also stated the difference between the v2 and v3 cli, this does not.

networkException avatar May 02 '24 14:05 networkException

hm I don't like how we're declaring this as "good practice" that are in fact (in practice) considered experimental in Nix. The previous description also stated the difference between the v2 and v3 cli, this does not.

The new description mentions that the v2 cli is old and will use the host nixpkgs, I think that's pretty descriptive enough?

Defining flakes as good practice is controversial, but it's the general way the community is going towards as it is more reproducible. Companies also prioritize flake support. (See DetSys, Hercules CI, Garnix and a few more which are all aimed towards flakes)

RGBCube avatar May 02 '24 17:05 RGBCube