serenity icon indicating copy to clipboard operation
serenity copied to clipboard

Meta: Replace all specific bootloader runners with environment variable

Open supercomputer7 opened this issue 3 years ago • 4 comments

Instead of adding specific runners in the run.sh script for bootloaders such as GRUB or Limine, let's have an environment variable, so users can choose their preference this way. This in turn simplifies the run script so only QEMU machine types and changes in need for specific VM runtimes are advertised in the SERENITY_RUN environment variable.

supercomputer7 avatar Apr 16 '22 08:04 supercomputer7

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions!

stale[bot] avatar May 09 '22 20:05 stale[bot]

This pull request has been closed because it has not had recent activity. Feel free to re-open if you wish to still contribute these changes. Thank you for your contributions!

stale[bot] avatar May 16 '22 22:05 stale[bot]

Let's try this again :)

supercomputer7 avatar Aug 20 '22 08:08 supercomputer7

This has a bunch of CI failures which look suspiciously related to QEMU startup?

linusg avatar Aug 29 '22 23:08 linusg

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions!

stale[bot] avatar Sep 20 '22 14:09 stale[bot]

This pull request has been closed because it has not had recent activity. Feel free to re-open if you wish to still contribute these changes. Thank you for your contributions!

stale[bot] avatar Sep 27 '22 16:09 stale[bot]