Josiah Noel

Results 151 comments of Josiah Noel

I tried to give it a go but it seems I can't run the unchanged project tests on my local. Getting a ton of errors like these. ``` [ERROR] BeanMapperMockTest.shouldSetValuesOnPublicSetter:154...

was running `make run-tests` from the command line only

``` Apache Maven 3.9.1 Java version: 20, vendor: Amazon.com Inc., ``` also yes I do use eclipse

so the only question I have then is what ServiceLoader interfaces do you guys use?

well it worked on my local ¯\\_(ツ)_/¯

> How do we test that the resulting modules work? Is that a new integration test? presumably the existing tests would work that out

Ah it seems make run-tests doesn't fully compile everything

it seems due to this peculiar ``` org.jdbi jdbi3-core tests test ``` thing, a couple modules can't get modularized since the classes within are not exported.

right now it seems I'll have to duplicate the classes in the core src/test and put them in the corresponding modules