SemanticResultFormats
SemanticResultFormats copied to clipboard
SemanticMediaWiki
Ensure, tests and CI are running with current SMW dev-master
@paladox can you have an eye on SRF too, so that the current work on SMW tests and CI is still compatible with SRF? Not 100% sure if this is related to the current changes in SMW:
https://github.com/SemanticMediaWiki/SemanticResultFormats/actions/runs/12375882361/job/34541714427#step:4:1639
Does this install the extension via composer or git clone it? As it'll be downloading the version from summer if it's the former.
Does this install the extension via composer or git clone it? As it'll be downloading the version from summer if it's the former.
Update: It does dev-master.
Deprecated: SMW\MediaWiki\Content\SchemaContent overrides prepareSave which was deprecated in MediaWiki 1.38. [Called from JsonContentHandler::validateSave in /var/www/html/includes/content/JsonContentHandler.php at line 75] in /var/www/html/includes/debug/MWDebug.php on line 381
Hmm that shouldn't be throwing if it was using dev-master?
Looks like it uses the version from composer.json and not the SMW_VERSION const.
It's not yet the latest docker-compose-ci as of today
It's up to https://github.com/gesinn-it-pub/docker-compose-ci/commit/d54a8ceaa4e6c0d12574729416eec819474307a4
Which the commits I did wouldn't fix this issue.
For some reason https://github.com/paladox/SemanticResultFormats/pull/1 passes for me. But fails here https://github.com/SemanticMediaWiki/SemanticResultFormats/pull/874
what happens, if you re-run checks on https://github.com/paladox/SemanticResultFormats/pull/1
Probably want to change CI on this repo to run for all users similar to SMW.
what happens, if you re-run checks on https://github.com/paladox/SemanticResultFormats/pull/1
It failed: https://github.com/paladox/SemanticResultFormats/actions/runs/12377136768/job/34546708612
I'm not sure why it fails.
From dev-master:
1) SRF\Tests\Integration\JSONScript\JsonTestCaseScriptRunnerTest::testCaseFile with data set "gallery-01.json" ('/var/www/html/extensions/Sema...1.json')
Failed "#0 (simple)"
==== (actual) ====
<div class="mw-parser-output"></div>
==== (StringContains expected) ====
[ <div class="srf-gallery" data-redirect-type="_wpg"> ], [ <div class="thumb" style="width: 150px;"><div style="margin:15px auto;"><a href=".*File:Gallery01.png" class="image"> ]
Failed asserting that 0 matches expected 2.
/var/www/html/extensions/SemanticResultFormats/extensions/SemanticMediaWiki/tests/phpunit/Utils/Validators/StringValidator.php:81
/var/www/html/extensions/SemanticResultFormats/extensions/SemanticMediaWiki/tests/phpunit/Utils/Validators/StringValidator.php:32
/var/www/html/extensions/SemanticResultFormats/extensions/SemanticMediaWiki/tests/phpunit/Utils/JSONScript/ParserTestCaseProcessor.php:215
/var/www/html/extensions/SemanticResultFormats/extensions/SemanticMediaWiki/tests/phpunit/Utils/JSONScript/ParserTestCaseProcessor.php:110
/var/www/html/extensions/SemanticResultFormats/extensions/SemanticMediaWiki/tests/phpunit/JSONScriptServicesTestCaseRunner.php:338
/var/www/html/extensions/SemanticResultFormats/extensions/SemanticMediaWiki/tests/phpunit/JSONScriptServicesTestCaseRunner.php:127
/var/www/html/extensions/SemanticResultFormats/extensions/SemanticMediaWiki/tests/phpunit/JSONScriptTestCaseRunner.php:237
/var/www/html/tests/phpunit/MediaWikiIntegrationTestCase.php:500
/var/www/html/extensions/SemanticResultFormats/extensions/SemanticMediaWiki/tests/phpunit/SMWIntegrationTestCase.php:205
from 4.2.0:
1) SRF\Tests\Integration\JSONScript\JsonTestCaseScriptRunnerTest::testCaseFile with data set "gallery-01.json" ('/var/www/html/extensions/Sema...1.json')
Failed "#0 (simple)"
==== (actual) ====
<div class="mw-parser-output"></div>
==== (StringContains expected) ====
[ <div class="srf-gallery" data-redirect-type="_wpg"> ], [ <div class="thumb" style="width: 150px;"><div style="margin:15px auto;"><a href=".*File:Gallery01.png" class="image"> ]
Failed asserting that 0 matches expected 2.
/var/www/html/extensions/SemanticResultFormats/extensions/SemanticMediaWiki/tests/phpunit/Utils/Validators/StringValidator.php:84
/var/www/html/extensions/SemanticResultFormats/extensions/SemanticMediaWiki/tests/phpunit/Utils/Validators/StringValidator.php:33
/var/www/html/extensions/SemanticResultFormats/extensions/SemanticMediaWiki/tests/phpunit/Utils/JSONScript/ParserTestCaseProcessor.php:216
/var/www/html/extensions/SemanticResultFormats/extensions/SemanticMediaWiki/tests/phpunit/Utils/JSONScript/ParserTestCaseProcessor.php:109
/var/www/html/extensions/SemanticResultFormats/extensions/SemanticMediaWiki/tests/phpunit/JSONScriptServicesTestCaseRunner.php:343
/var/www/html/extensions/SemanticResultFormats/extensions/SemanticMediaWiki/tests/phpunit/JSONScriptServicesTestCaseRunner.php:127
/var/www/html/extensions/SemanticResultFormats/extensions/SemanticMediaWiki/tests/phpunit/JSONScriptTestCaseRunner.php:234
/var/www/html/extensions/SemanticResultFormats/extensions/SemanticMediaWiki/tests/phpunit/DatabaseTestCase.php:192
Happens with https://github.com/SemanticMediaWiki/SemanticResultFormats/blob/master/tests/phpunit/Integration/JSONScript/TestCases/gallery-01.json
But I can't figure out why it fails. The fact it seems to happen with version 4.2 and even 4.1.3 seems to indicate there's a bug. Either the test is broken or there's a bug some where around the extension? or could be SMW idk.
I don't seem to know how to fix this though after looking.
@gesinn-it-gea https://github.com/paladox/SemanticResultFormats/pull/1 works now when I changed the commands in the composer file.