Changes made to $wgCanonicalNamespaceNames in MediaWiki 1.34

[dominic998]

Setup and configuration

N/A

Issue

A change has been made to $wgCanonicalNamespaceNames in MediaWiki core (see T232004).

We now explicitly set $wgCanonicalNamespaceNames[NS_MAIN].

I believe this might affect the union done here, if the code assumes $wgCanonicalNamespaceNames[NS_MAIN] is not already set. Any value of the main namespace returned by $instance->getCanonicalNames() will be ignored.

This change will be in 1.34.wmf.22

Raising this bug here just so you are aware and can take the necessary actions.

Stack trace

N/A

Steps to reproduce

N/A

[kghbln]

Thanks for notifying.

[JeroenDeDauw]

Code now at https://github.com/SemanticMediaWiki/SemanticMediaWiki/blob/master/src/NamespaceManager.php#L206

[akuckartz]

What is left to be done here?

[JeroenDeDauw]

Figuring out if there actually is an issue and potentially fixing it