Semantic-UI icon indicating copy to clipboard operation
Semantic-UI copied to clipboard

Issue #7122 Burmese Flag correction

Open syang0624 opened this issue 2 years ago • 3 comments

Issue Titles

https://github.com/Semantic-Org/Semantic-UI/issues/7122

[Flag] - Shows the Flag of Taiwan when try to use Burmese Flag #7122

Description

Was reading the documentation here: https://react.semantic-ui.com/elements/flag/#types-flag

but realized that the main example uses the Taiwan flag but in the code, it says Myanmar

Testcase

Expected When using Myanmar flag:

Instead of Showing 🇹🇼 should show 🇲🇲 Result Currently shows 🇹🇼 when using the Myanmar flag

syang0624 avatar Sep 14 '23 03:09 syang0624

Most of the add/deletion is based on the rc settings from the original library to just make css prettier.

However, the key update here is: SemanticUI was showing 🇹🇼 when the user wanted a Burmese flag. It should show 🇲🇲

Fixed with this PR!

syang0624 avatar Sep 14 '23 03:09 syang0624

is the project abandoned?

OTonGitHub avatar May 08 '24 02:05 OTonGitHub

is the project abandoned?

honestly I am not sure. the PR was approved last December, but no one merged it.

syang0624 avatar May 08 '24 02:05 syang0624