Semantic-UI-React icon indicating copy to clipboard operation
Semantic-UI-React copied to clipboard

replace loadsh invoke with optional chaining

Open thing18 opened this issue 2 years ago • 2 comments
trafficstars

thing18 avatar May 13 '23 09:05 thing18

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

welcome[bot] avatar May 13 '23 09:05 welcome[bot]

@thing18 you need to remove some of Lodash imports as in some files it was a single usage. Run yarn lint locally to detect failures.

layershifter avatar May 16 '23 08:05 layershifter