Semantic-UI-React icon indicating copy to clipboard operation
Semantic-UI-React copied to clipboard

v3: roadmap to release

Open layershifter opened this issue 2 years ago • 36 comments
trafficstars

This PR tracks work for Semantic UI React v3 🎉

Pre beta-0 ✅

  • [x] chore: replace ta-scripts with release-it

For beta-0 ✅

  • [x] All components support native ref forwarding #4233
  • [x] BREAKING CHANGE remove Ref component #4286
  • [x] BREAKING CHANGE remove Visibility component #4257
  • [x] BREAKING CHANGE Input, Button & TextArea are forwarding refs to native elements
  • [x] BREAKING CHANGE Transition static props #4266

Post beta-0 ✅

  • [x] Document breaking changes #4431

For beta-2 ✅

  • [x] fix: remove usages of .defaultProps #4426, see https://github.com/Semantic-Org/Semantic-UI-React/issues/4426#issuecomment-1627680271
  • [x] chore: update typings, ensure that they support ref forwarding #4432, see https://github.com/Semantic-Org/Semantic-UI-React/issues/4432#issuecomment-1627741193
  • [x] #4433

For beta-3

  • [x] #4457
  • [x] #4490
  • [ ] BREAKING CHANGE Event handling: remove eventStack
  • [ ] test: validateTrigger should handle forwardRef
  • [ ] chore: remove .displayName in production
  • [ ] docs: update contributing guide
  • [ ] docs: update Github templates
  • [ ] docs: update introduction to remove AutoControlledComponent mentions
  • [ ] docs: rename classname generators (currently they violate rules of hooks as their names start with use)
  • [x] chore: enable ESLint plugin for rules of hooks #4498

For RC

  • [ ] chore: integrate monosize
  • [ ] chore: add bundle size fixtures for all components
  • [ ] chore: remove dependency on lodash
  • [ ] chore: deprecate "dot-syntax"
    • [ ] add warnings
    • [ ] add a codemod

After release

  • [ ] docs: update CodeSandbox templates

layershifter avatar Dec 13 '22 11:12 layershifter

@layershifter what is the status user.React.forwardRef PR status? I see it is still in open

vinodhrajamuralidharan avatar Jan 29 '23 10:01 vinodhrajamuralidharan

@vinodhrajamuralidharan I had a conversation with @levithomason about that PR. The agreement was that he will review it and then we can proceed. I am also waiting for that PR to be merged 😉

layershifter avatar Jan 30 '23 12:01 layershifter

Is there any ETA on v3 progress @levithomason / @layershifter ? There was such a great traction in December, so I started to get my hopes up for SUIR again 🤞 Would hate to see it stall again, with all the great work that has been put in to it 🙏

sunech avatar Feb 21 '23 21:02 sunech

3.0.0-beta.0 is out 🎉 Please try and report issues 🙏

layershifter avatar Feb 28 '23 17:02 layershifter

Thanks a lot @layershifter for the effort! I didn't run into any issues yet with the beta besides the probably expected Typescript issues such as https://stackblitz.com/edit/react-ts-ejdyij?file=App.tsx.

DreierF avatar Mar 19 '23 11:03 DreierF

Is there anything further that we can help test, in order to proceed with the v3 release?

sunech avatar Jun 16 '23 17:06 sunech

@layershifter could you please update the status? FYI @levithomason

  1. Is the roadmap todo list still relevant? If not, please refresh or update it. In particular, please add the links to the appropriate PRs, branches, etc.
  2. Please add more clear description for each point. E.g. what is Document breaking changes that is not checked?
  3. If you are not about to move on with the project, please initiate a process to pass it to the community. There are projects and people who are waiting for the new version trying to replace SUIR with a fork or something else.

tourman avatar Jul 04 '23 11:07 tourman

@tourman

1/2. Yes, it's relevant. I will update it to be more precise and detailed 👍 3. To be clear, I don't have time and motivation to maintain this project currently. If there people who are interested in move forward it would be great to hear back 🐱

layershifter avatar Jul 04 '23 11:07 layershifter

@layershifter thank you for all you great work so far, highly appreciate your effort!

This project is too good to just die, so I really hope someone wants to pick up from here. Would love to support if I can, not experienced enough to contribute with code though. If any freelancers are considering, I would gladly pay for some of your time to get the ball rolling on this again.

sunech avatar Jul 04 '23 13:07 sunech

Thanks a lot @layershifter for the effort! I didn't run into any issues yet with the beta besides the probably expected Typescript issues such as https://stackblitz.com/edit/react-ts-ejdyij?file=App.tsx.

@DreierF it's indeed a bug, see #4432 for details.

Is there anything further that we can help test, in order to proceed with the v3 release?

@sunech @tourman I updated changelog and created migration guide (https://react.semantic-ui.com/migration-guide). I also updated issues that needs to be solved to release the next beta. Both issues contain action items and examples of changes needed to be done.

Help on these issues is much appreciated 🐱

layershifter avatar Jul 09 '23 15:07 layershifter

@layershifter thanks for your work on this package, do you have approximate time when you plan to release 3.0 version?

siarheipashkevich avatar Dec 21 '23 15:12 siarheipashkevich

3.0.0-beta.2 is out 🎉

It fixes .defaultProps warnings, TypeScript typings & issues with appDir in Next.js.

Please try and report issues 🙏

layershifter avatar Dec 30 '23 15:12 layershifter

I can report that after making a few small changes all frontend unit tests of Quality-time pass with 3.0.0-beta.2:

Test Suites: 85 passed, 85 total
Tests:       694 passed, 694 total
Snapshots:   0 total
Time:        67.751 s, estimated 70 s

Most changes were needed because popups would not appear at the right position with 3.0.0-beta.2. Adding a span or div around triggers solved this. I can't reproduce this issue on the Semantic UI React documentation site so I guess it's an issue on our side.

fniessink avatar Jan 05 '24 12:01 fniessink

I don't think that it's worth creating a issue but the Sticky component didn't work after the upgrade. I needed to add scrollContext because there is a scrollable div instead of whole window. I am not sure if it's somehow breaking change or I had it wrong even before. I am just mentioning as a possible information to migration guide.

dominikdosoudil avatar May 06 '24 13:05 dominikdosoudil

I can report that after making a few small changes all frontend unit tests of Quality-time pass with 3.0.0-beta.2:

Test Suites: 85 passed, 85 total
Tests:       694 passed, 694 total
Snapshots:   0 total
Time:        67.751 s, estimated 70 s

Most changes were needed because popups would not appear at the right position with 3.0.0-beta.2. Adding a span or div around triggers solved this. I can't reproduce this issue on the Semantic UI React documentation site so I guess it's an issue on our side.

This seems to also be an issue on our side. Started with the transition to beta.2 and adding a span around it indeed fixed it

Noahkoole avatar May 25 '24 15:05 Noahkoole

@layershifter - I fixed the first task in the beta-3 release. Could you please add issues for the rest of tasks in the list and I'll see if I can have a go at some of them? Would be nice to get v3 out!

atti187 avatar Jun 26 '24 12:06 atti187