Semantic-UI-CSS icon indicating copy to clipboard operation
Semantic-UI-CSS copied to clipboard

Remove extra semi-colon from step.css also

Open sahi1422 opened this issue 3 years ago • 1 comments

@jlukic @levithomason , I forgot to remove the semi-colon from the step.css

https://github.com/Semantic-Org/Semantic-UI-CSS/pull/76

sahi1422 avatar Dec 17 '21 14:12 sahi1422

Is there a reason this is still open? I can confirm this is the same exact edit I have to do to get it working with webpack 5.

ajohnston1219 avatar Feb 10 '22 19:02 ajohnston1219

Are there any updates on why this isn't merged yet?

R3DST0RM avatar Aug 22 '22 10:08 R3DST0RM

@fniessink or maybe @peacekeeper or @sahi1422 ? Also, a version bump would be awesome, @sahi1422

guslen avatar Sep 15 '22 15:09 guslen

@jlukic will you merge this? Also, a version bump would be excellent. 😄

guslen avatar Sep 16 '22 09:09 guslen

@peacekeeper, do you know who can merge this pull request?

guslen avatar Sep 20 '22 06:09 guslen

Sorry I don't know.. I also wish this could be merged.

peacekeeper avatar Sep 20 '22 07:09 peacekeeper

@peacekeeper

Sorry I don't know.. I also wish this could be merged.

I sent an email to [email protected] with this content: Subject:

Who can merge PR in Semantic css

Content:

Hi, We need a merge and a version bump for semantic-ui-css. ~~jlucik~~ @jlukic doesn't seem to react even after tagging him. I don't know who is in charge of the repo. this is the PR in question https://github.com/Semantic-Org/Semantic-UI-CSS/pull/77#issue-1083335401

Thank you for the help.

Best regards, Gustav Lennart Voigt

guslen avatar Sep 20 '22 07:09 guslen

These repos are automatically generated from the main Semantic UI repo with a release bot.

You will need to make any PR requests off the main repo src/ folder if there's a typo.

You can find the correct file here https://github.com/Semantic-Org/Semantic-UI/blob/master/src/themes/default/elements/step.overrides#L5

jlukic avatar Sep 20 '22 23:09 jlukic

I've gone ahead and run the release bot to publish the changes from the main repo @sahi1422

jlukic avatar Oct 06 '22 17:10 jlukic