Semantic-UI-CSS icon indicating copy to clipboard operation
Semantic-UI-CSS copied to clipboard

Breaking change in 2.3.0 from ^2.2.12 - Icons not loading, Modal position incorrect

Open OwenPattison opened this issue 7 years ago • 13 comments

Setup: semantic-ui-css: 2.3.0 node: 6.13.0

Problem: Today i ran into an issue whereby none of the semantic ui icons would load also my modal elements were incorrectly positioned on the page.

Solution: Downgrade and lock to version 2.2.14

OwenPattison avatar Feb 20 '18 17:02 OwenPattison

same problem, can't find the icons, it appears that the default theme folder remains empty. This is not related to semantic-ui-css 2.3, I missed them even when downgrading

ticruz38 avatar Feb 21 '18 14:02 ticruz38

Same problem here, had to downgrade to 2.2.14. Otherwise modal window position is wrong and icons not showing.

Yunoo avatar Feb 22 '18 14:02 Yunoo

Having the same problem with the modal

jkudish avatar Feb 23 '18 19:02 jkudish

Same problem with modal

monkalways avatar Feb 28 '18 00:02 monkalways

Same here.

Norbk avatar Mar 04 '18 22:03 Norbk

I have the modal problem. Icons are ok.

I'm using [email protected], [email protected] and [email protected]. Downgrading both semantic-ui and semantic-ui-css to 2.2.14 is a valid workaround.

taschetto avatar Mar 08 '18 01:03 taschetto

A CSS fix in case you don't want to downgrade:

// Semantic UI modal position fix
.ui.active.dimmer.modals.transition {
    display: flex !important;
    display: -ms-flexbox !important;
}

NotAmaan avatar Mar 10 '18 14:03 NotAmaan

+1 happens to me too. but downgrading exposes another bug which was fixed in 2.3.0, so I'm having a bug deadlock :)

yossi-shasho avatar Mar 12 '18 10:03 yossi-shasho

Just adding my voice - got the same thing happening - modal showing in the top left corner after updating CSS to 2.3.0. Reverting to 2.2.14 fixes it.

codeaid avatar Mar 12 '18 16:03 codeaid

I surprised, how long this issue in open state.

darky avatar Mar 12 '18 18:03 darky

The issue is being caused by this styling, which uses !important and overides the display:flex property on the modal dimmer.

.visible.transition {
    display: block!important;
    visibility: visible!important;
}

Surprised this wasn't caught in testing.

chrispaynter avatar Mar 13 '18 21:03 chrispaynter

Modal broken for me too.

dmulter avatar Apr 08 '18 19:04 dmulter

I don't think @jlukic is monitoring issues in this repo. I advise all issues be reported to https://github.com/Semantic-Org/Semantic-UI/issues

@jlukic , can we make this repo read-only being that it's only an automatically synced image of the main repo?

avalanche1 avatar Apr 26 '18 02:04 avalanche1