seleniumhq.github.io
seleniumhq.github.io copied to clipboard
Added README to run Java Examples (#1160)
User description
Added README to run Java Example and also updated the first_script.en.md file with instructions to run first Java Example
Description
Added examples\java\src\test\java\README.md to run Java Example and also updated the website_and_docs\content\documentation\webdriver\getting_started\first_script.en.md file with instructions to run first Java Example
Motivation and Context
Documentation to run first Java Example was missing.
Types of changes
- [x] Change to the site (I have double-checked the Netlify deployment, and my changes look good)
- [ ] Code example added (and I also added the example to all translated languages)
- [ ] Improved translation
- [ ] Added new translation (and I also added a notice to each document missing translation)
Checklist
- [x] I have read the contributing document.
- [x] I have used hugo to render the site/docs locally and I am sure it works.
PR Type
Documentation
Description
- Added a new README file in
examples/java/src/test/java/with detailed instructions on how to run all Java test examples and the first Java example using Maven. - Updated
website_and_docs/content/documentation/webdriver/getting_started/first_script.en.mdto link to the new README for running the first Java example.
Changes walkthrough 📝
| Relevant files | |||||
|---|---|---|---|---|---|
| Documentation |
|
💡 PR-Agent usage: Comment
/helpon the PR to get a list of all available PR-Agent tools and their descriptions
Deploy request for selenium-dev pending review.
Visit the deploys page to approve it
| Name | Link |
|---|---|
| Latest commit | d82ef8aa8d69255d246998335bf9caef4a14a935 |
PR Reviewer Guide 🔍
| ⏱️ Estimated effort to review [1-5] | 2 |
| 🧪 Relevant tests | No |
| 🔒 Security concerns | No |
| ⚡ Key issues to review | None |
PR Code Suggestions ✨
| Category | Suggestion | Score |
| Clarity |
Clarify that Maven should be installed before running the
| 7 |
| Best practice |
Add a note to ensure the JAVA_HOME environment variable is set correctly before running Maven commandsAdd a note to ensure that the JAVA_HOME environment variable is set correctly before examples/java/src/test/java/README.md [26]
Suggestion importance[1-10]: 7Why: This suggestion is helpful for ensuring the environment is correctly set up, which is important for successful execution of Maven commands. | 7 |
HI @reply2sagar ,
Thank you for the PR. I have replaced this PR with commit https://github.com/SeleniumHQ/seleniumhq.github.io/commit/acbde0c44a0a9644bbb928eb97efb7384a343b31!