seleniumhq.github.io
seleniumhq.github.io copied to clipboard
Add VirtualAuthenticator tests to Ruby examples
Description
- Added tests for the Ruby example project that verify & document the VirtualAuthenticator API
- Note that one test is failing; I wasn't able to figure out what incantation of Base64 decoding/encoding was necessary
Motivation and Context
- Adding these tests helps document how the Selenium library can be used with virtual authenticators
Types of changes
- [x] Code example added (and I also added the example to all translated languages)
Checklist
- [x] I have read the contributing document.
- [ ] I have used hugo to render the site/docs locally and I am sure it works.
Deploy request for selenium-dev pending review.
Visit the deploys page to approve it
| Name | Link |
|---|---|
| Latest commit | 371e07ec3a269d34135e74137c8e3c4504c43863 |
@tcannonfodder can you merge trunk into your branch? Or make the PR editable so we can do that for you.
Done!
Please check the linter errors.
It is easier if you let us update your branch because we are merging other PRs and yours will be out of date.
Hey there!
I’m not seeing the option to do so on my end :/, based on these docs: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork
OK. Why don't you skip the failed test and leave a note on it?
@diemol. I tried getting the latest trunk and creating a new PR, #2429. I didn't see any options to explicitly allow maintainers to make changes to the branch, but I'm assuming y'all will be able to. As an extra precaution, I'll add you as a contributor to the forked repository.
Thanks. I will close this one and follow up on the other one.