seleniumhq.github.io icon indicating copy to clipboard operation
seleniumhq.github.io copied to clipboard

Add VirtualAuthenticator tests to Ruby examples

Open tcannonfodder opened this issue 2 years ago • 2 comments

Description

  • Added tests for the Ruby example project that verify & document the VirtualAuthenticator API
  • Note that one test is failing; I wasn't able to figure out what incantation of Base64 decoding/encoding was necessary

Motivation and Context

  • Adding these tests helps document how the Selenium library can be used with virtual authenticators

Types of changes

  • [x] Code example added (and I also added the example to all translated languages)

Checklist

  • [x] I have read the contributing document.
  • [ ] I have used hugo to render the site/docs locally and I am sure it works.

tcannonfodder avatar Nov 29 '23 05:11 tcannonfodder

Deploy request for selenium-dev pending review.

Visit the deploys page to approve it

Name Link
Latest commit 371e07ec3a269d34135e74137c8e3c4504c43863

netlify[bot] avatar Nov 29 '23 05:11 netlify[bot]

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Nov 29 '23 05:11 CLAassistant

@tcannonfodder can you merge trunk into your branch? Or make the PR editable so we can do that for you.

diemol avatar Aug 16 '25 19:08 diemol

Done!

tcannonfodder avatar Aug 16 '25 19:08 tcannonfodder

Please check the linter errors.

It is easier if you let us update your branch because we are merging other PRs and yours will be out of date.

diemol avatar Aug 16 '25 19:08 diemol

Hey there!

I’m not seeing the option to do so on my end :/, based on these docs: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

image

tcannonfodder avatar Aug 16 '25 20:08 tcannonfodder

OK. Why don't you skip the failed test and leave a note on it?

diemol avatar Aug 16 '25 20:08 diemol

@diemol. I tried getting the latest trunk and creating a new PR, #2429. I didn't see any options to explicitly allow maintainers to make changes to the branch, but I'm assuming y'all will be able to. As an extra precaution, I'll add you as a contributor to the forked repository.

tcannonfodder avatar Aug 18 '25 15:08 tcannonfodder

Thanks. I will close this one and follow up on the other one.

diemol avatar Aug 18 '25 18:08 diemol