[dotnet] Fully annotate `Command` for AOT support

[RenderMichael]

User description

AOT warnings are user-facing, even if those warnings are within Selenium's own code. For that reason, we should ensure we are not emitting any warnings unless such code paths are annotated as AOT-unsafe.

Motivation and Context

Contributes to https://github.com/SeleniumHQ/selenium/issues/14480

Types of changes

• [ ] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• [x] I have read the contributing document.
• [ ] My change requires a change to the documentation.
• [ ] I have updated the documentation accordingly.
• [ ] I have added tests to cover my changes.
• [x] All new and existing tests passed.

---

PR Type

Enhancement

---

Description

• Added AOT-friendly annotations to the Command class.

• Refactored JsonSerializerOptions into a static nested class for safety.

• Introduced helper methods for parameter handling in Command.

• Updated HttpCommandInfo to use new parameter handling methods.

---

Changes walkthrough 📝

Relevant files

Enhancement

Command.cs Refactor `Command` class for AOT compatibility                      dotnet/src/webdriver/Command.cs Added AOT and trimming annotations to methods and properties. Refactored JsonSerializerOptions into a static nested class. Introduced HasParameters and TryGetValueAndRemoveIfNotNull helper methods. Updated parameter handling logic for better AOT support. +50/-12  HttpCommandInfo.cs Update parameter handling in `HttpCommandInfo`                      dotnet/src/webdriver/HttpCommandInfo.cs Replaced direct parameter access with HasParameters and TryGetValueAndRemoveIfNotNull. Improved parameter extraction logic for AOT compatibility. +3/-7

---

Need help?

Type /help how to ... in the comments thread for any questions about Qodo Merge usage.

Check out the documentation for more information.

[qodo-merge-pro[bot]]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis ✅ 14480 - PR Code Verified Compliant requirements: Contributes to making Selenium .NET library compatible with Native AOT Deployment Addresses AOT-unfriendly code in the Command class Requires further human verification: Verify that the changes actually resolve runtime failures when applications using Selenium are published as native AOT Confirm that all necessary AOT annotations have been added to the Command class

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review AOT Annotation Completeness The PR adds AOT annotations to the Command class, but it's important to verify that all methods that could potentially use reflection or dynamic code generation are properly annotated with RequiresUnreferencedCode and RequiresDynamicCode attributes. [RequiresUnreferencedCode("Adding untyped parameter values for JSON serialization has best-effort AOT support. Ensure only Selenium types and well-known .NET types are added, or use the overload that takes pre-serialized string jsonParameters for guaranteed AOT compatibility.")] [RequiresDynamicCode("Adding untyped parameter values for JSON serialization has best-effort AOT support. Ensure only Selenium types and well-known .NET types are added, or use the overload that takes pre-serialized string jsonParameters for guaranteed AOT compatibility.")] public Command(SessionId? sessionId, string name, Dictionary<string, object?>? parameters) Parameter Handling The new TryGetValueAndRemoveIfNotNull method changes the behavior of parameter handling. Verify that this change doesn't affect existing functionality, especially in edge cases with null values. internal bool TryGetValueAndRemoveIfNotNull(string key, [NotNullWhen(true)] out object? value) { if (this._parameters.TryGetValue(key, out value)) { if (value is not null) { this._parameters.Remove(key); return true; } } return false; }

[qodo-merge-pro[bot]]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
General	Set output parameter consistently The method should set value to null when returning false to ensure consistent behavior. Currently, if the key exists but the value is null, the method returns false but value remains set to null from TryGetValue, which could be confusing. dotnet/src/webdriver/Command.cs [128-140] internal bool TryGetValueAndRemoveIfNotNull(string key, [NotNullWhen(true)] out object? value) { if (this._parameters.TryGetValue(key, out value)) { if (value is not null) { this._parameters.Remove(key); return true; } } + value = null; return false; } [ ] Apply this suggestion Suggestion importance[1-10]: 7 __ Why: The suggestion correctly identifies an issue with the out parameter behavior. When returning false, explicitly setting value=null ensures consistent behavior regardless of whether the key exists with a null value or doesn't exist at all, which improves method reliability and prevents potential bugs.	Medium
[ ] Update

[nvborisenko]

This is show stopper: https://github.com/SeleniumHQ/selenium/pull/15527#discussion_r2101241067